-
-
Notifications
You must be signed in to change notification settings - Fork 515
Enable language packs #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing this build, I see only the localizations provided by the language pack.
From the mention of the Transifex coverage being a factor in the decision regarding which language packs to install, I anticipated seeing the Arduino IDE-specific localization as well.
Will some additional work be needed on the IDE before we will see #768 have an effect?
When testing this build, I see only the localizations provided by the language pack.
yeah, it's still not working. Trying to figure out why.
arduino-ide-extension/src/node/arduino-localization-contribution.ts
Outdated
Show resolved
Hide resolved
1c6e8b0 to
9ed46f9
Compare
9ed46f9 to
fc4bba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fcbc1c3 to
b4ba0ac
Compare
b4ba0ac to
5a48dc5
Compare
@per1234 this time I'm really confident that it will work! Please check once again 🙏
arduino-ide-extension/src/node/arduino-localization-contribution.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very exciting to see the localization of the IDE.
Thanks Alberto!
And thanks also to the translators for their valuable contributions to the project.
stevisco
commented
Apr 8, 2022
this is super cool!
kotobuki
commented
Apr 9, 2022
I am a contributor to Japanese, and I'm very excited to see the localised IDE. I found that some of the language resources (e.g. Undo, Redo etc.) are not from Arduino SRL -Arduino IDE 2.0 nor Mbanzi - Arduino IDE 1.5. I found inconsistencies in them, so I want to update them. Where do those localisations come from? 🤔
Hi @kotobuki. Thanks so much for your contributions and for your attention to the quality of the current localization!
The VS Code "language packs" are used as the localization source where possible so that the Arduino community only needs to localize the Arduino-specific strings rather than having to duplicate the efforts already made for the strings which are shared with VS Code.
The VS Code language pack used for the base Japanese localization is hosted here:
https://github.com/Microsoft/vscode-loc
Note that their system does not allow direct contribution to the content via pull requests to the repository. Instead, it is done by submitting issues to the repository, which will then be acted on by someone from Microsoft.
kotobuki
commented
Apr 9, 2022
@per1234 Thank you very much for the detailed explanation. I understand. I'll do my best for Arduino IDE specific resources and propose changes to the VSC repository.
qizaizi
commented
Apr 10, 2022
The plugin directory is in the installation location arduino2.0\Arduino IDE\resources\app\plugins
Uh oh!
There was an error while loading. Please reload this page.
Motivation
We want to add the language packs whose translations have enough coverage on Transifex
Change description
Install the relative VS Code language pack extensions.
Adding the following languages:
Reviewer checklist