-
-
Notifications
You must be signed in to change notification settings - Fork 514
Minified browser code in the packaged final app. #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -227,8 +227,7 @@ ${fs.readFileSync(path('..', 'build', 'package.json')).toString()} | |
| 'Installing dependencies' | ||
| ); | ||
| exec( | ||
| `yarn --network-timeout 1000000 --cwd ${path('..', 'build')} build${isElectronPublish ? ':publish' : '' | ||
| }`, | ||
| `yarn --network-timeout 1000000 --cwd ${path('..', 'build')} build`, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice one @kittaakos. Just one thing: wouldn't it be better if we'd set That way we could still use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out why it did not work 👍
Good point, but when do we need a packaged app for dev mode? I could not come up with a single use-case. I think I also collected a pros-cons list if we decide always to minify the code: Pros:
Cons:
What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I thought source maps wouldn't work in production mode. In that case, I guess the pros outweigh the cons. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Please double check if you can also debug the TS code in the bundled app. Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yup, everything seems to work for me. Thanks @kittaakos! |
||
| `Building the ${productName} application` | ||
| ); | ||
| exec( | ||
|
|
@@ -488,7 +487,6 @@ ${fs.readFileSync(path('..', 'build', 'package.json')).toString()} | |
| )}.` | ||
| ); | ||
| shell.exit(1); | ||
| process.exit(1); | ||
| } | ||
| if (expectedVersion) { | ||
| if (!versions.has(expectedVersion)) { | ||
|
|
@@ -497,7 +495,6 @@ ${fs.readFileSync(path('..', 'build', 'package.json')).toString()} | |
| }'.` | ||
| ); | ||
| shell.exit(1); | ||
| process.exit(1); | ||
| } | ||
| } | ||
| } | ||
|
|
||