Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Splashscreen fixes #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
80avin wants to merge 2 commits into arduino:main from 80avin:splashscreen-fixes
Closed

Splashscreen fixes #851

80avin wants to merge 2 commits into arduino:main from 80avin:splashscreen-fixes

Conversation

@80avin
Copy link

@80avin 80avin commented Feb 20, 2022

Fixes

  1. prevent splashscreen from starting alwaysOnTop
  2. prevent pointer events like drag on splash screen

Note: I saw #717 but the approach is different.

per1234 and AlbyIanna reacted with heart emoji
Copy link

CLAassistant commented Feb 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added the topic: code Related to content of the project itself label Feb 20, 2022
@AlbyIanna AlbyIanna requested review from AlbyIanna, fstasi and ubidefeo and removed request for fstasi February 24, 2022 10:55
Copy link
Contributor

fstasi commented Feb 24, 2022 •
edited
Loading

Hi @80avin ,

thanks for contributing, we definitely need some work on the splash screen.
I tested on mac and I see some behavior we should try to address:

  • the splash screen pops up
  • it is immediateley covered by the IDE main window (blank)

I'd get rid of the splash screen, we don't need it anymore.

@80avin let me know if this is something that can be addressed in this PR

Copy link

mostpinkest commented Mar 3, 2022 •
edited
Loading

  • the splash screen pops up
  • it is immediateley covered by the IDE main window (blank)

@80avin I know setting alwaysOnTop to false would be far simpler, but this is why #717 takes a different approach.

I've also noticed that using pointer-events: none; still allows the splash screen to be highlighted if it's double clicked.

@kittaakos kittaakos self-assigned this Aug 3, 2022
kittaakos pushed a commit that referenced this pull request Aug 4, 2022 
Added a bare minimum example.
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 4, 2022 
Added a bare minimum example.
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 4, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 4, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 4, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 4, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 5, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 5, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 5, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 5, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 9, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 9, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 9, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this pull request Aug 9, 2022 
Added a bare minimum example.
Closes #193
Closes #324
Closes #327
Closes #717
Closes #851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Aug 9, 2022
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this pull request Aug 10, 2022 
Added a bare minimum example.
Closes arduino#193
Closes arduino#324
Closes arduino#327
Closes arduino#717
Closes arduino#851
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Labels

conclusion: duplicate Has already been submitted topic: code Related to content of the project itself

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Splash Screen Can be Clicked and Dragged as an Image Splash Screen Should not be Always on Top

AltStyle によって変換されたページ (->オリジナル) /