-
-
Notifications
You must be signed in to change notification settings - Fork 512
Add commands and workflows to handle translations #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@silvanocerza
silvanocerza
added
type: enhancement
Proposed improvement
status: in progress
Work is in progress on this
topic: infrastructure
Related to project infrastructure
labels
Oct 11, 2021
@silvanocerza
silvanocerza
force-pushed
the
scerza/i18n
branch
from
October 18, 2021 12:14
44b62c9 to
00adb3e
Compare
per1234
per1234
requested changes
Oct 25, 2021
per1234
per1234
requested changes
Oct 25, 2021
per1234
per1234
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the workflow syntax, but that part looks good to me.
Very exciting to see the i18n initiative moving forward. Thanks Silvano!
...source file is updated when necessary
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
@silvanocerza
silvanocerza
force-pushed
the
scerza/i18n
branch
from
November 4, 2021 13:48
d49cce1 to
3fea5b5
Compare
@silvanocerza
silvanocerza
force-pushed
the
scerza/i18n
branch
from
November 4, 2021 13:54
790c020 to
bc0177d
Compare
rsora
rsora
approved these changes
Nov 4, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Add four
yarncommands:i18n:generateto generate the source json file that contains all translatable stringsi18n:checkto verify that the source json file is updated with new stringsi18n:pushto push source file json file to Transifexi18n:pullto pull translation files from TransifexAlso add three new workflows:
check-i18n-task.ymlto verify that each PR updates the source json file ini18nif necessaryi18n-nightly-push.ymlto push source file json file to Transifex each nighti18n-weekly-pull.ymlto pull translation files from Transifex each MondayThe workflow currently in use in the arduino/arduino-cli repo is not usable for this project since the release process is different.