-
-
Notifications
You must be signed in to change notification settings - Fork 511
[ATL-1294] At first ide startup invoke installation of arduino:avr #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use a const rather than just a string.
I'm also wondering if a more expressive string that relates to it's purpose is better
something like
const INIT_AVR_PACKAGES = 'initializedAvrPackages';
c080392 to
90046c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Win 🆗
Linux 🆗
ShineUnM
commented
Sep 4, 2021
Maybe, Let user to choose installing the AVR core lib or not is better?
For example, I never use AVR, now I have to wait it installing and remove it, and install my target core lib
Maybe, Let user to choose installing the AVR core lib or not is better?
For example, I never use AVR, now I have to wait it installing and remove it, and install my target core lib
@ShineUnM this PR is meant to close the gap between the IDE2 beta and the current IDE. The latter ships with AVR core pre-installed in order to make the experience as forgiving as possible for newcomers.
I'll discuss your comment with the UX team and evaluate if we can find a suitable solution for more advanced users.
Feel free to open an issue so that we can track your request and collect other feedback.
thanks a lot
HOW
Use
LocalStorageServiceto know if it's the first IDE startup, and in that case launcharduino:avrinstallation.