Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ATL-1599] [ATL-1416] Upgrade Theia to 1.18.0 #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fstasi merged 22 commits into main from theia-upgrade
Oct 6, 2021
Merged

[ATL-1599] [ATL-1416] Upgrade Theia to 1.18.0 #489

fstasi merged 22 commits into main from theia-upgrade
Oct 6, 2021

Conversation

@fstasi
Copy link
Contributor

@fstasi fstasi commented Aug 30, 2021
edited
Loading

Why

Upgrading Theia from 1.12.0 to 1.18.0

How

  • Updated package.json to use fixed version of theia, rather than next. This will make the workflow more clear and easier when updating theia: no need to wipe yarn.lock file anymore.
  • resolved a number of breaking changes
  • updated icons as theia moved from font awesome to codicons and we need a consistent look and feel in the left bar

Tasks

ATL-1599
ATL-1416

@fstasi fstasi requested a review from AlbyIanna August 30, 2021 09:44
@AlbyIanna AlbyIanna changed the title (削除) [ATL-1599] [ATL-1599] Upgrade Theia to 1.17.0 (削除ここまで) (追記) [ATL-1599] [ATL-1416] Upgrade Theia to 1.17.0 (追記ここまで) Aug 30, 2021
},
"scripts": {
"prepare": "cross-env THEIA_ELECTRON_SKIP_REPLACE_FFMPEG=1 lerna run prepare && yarn download:plugins",
"cleanup": "npx rimraf ./**/node_modules && rm -rf ./node_modules ./.browser_modules ./arduino-ide-extension/build ./arduino-ide-extension/downloads ./arduino-ide-extension/Examples ./arduino-ide-extension/lib ./browser-app/lib ./browser-app/src-gen ./browser-app/gen-webpack.config.js ./electron-app/lib ./electron-app/src-gen ./electron-app/gen-webpack.config.js",
Copy link
Contributor

@AlbyIanna AlbyIanna Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

@fstasi fstasi force-pushed the theia-upgrade branch 3 times, most recently from 5738482 to 03acb58 Compare September 8, 2021 07:56
@fstasi fstasi changed the title (削除) [ATL-1599] [ATL-1416] Upgrade Theia to 1.17.0 (削除ここまで) (追記) [ATL-1599] [ATL-1416] Upgrade Theia to 1.17.1 (追記ここまで) Sep 8, 2021
# Conflicts:
#	arduino-ide-extension/package.json
#	browser-app/package.json
#	electron-app/package.json
#	yarn.lock
# Conflicts:
#	yarn.lock
@fstasi fstasi changed the title (削除) [ATL-1599] [ATL-1416] Upgrade Theia to 1.17.1 (削除ここまで) (追記) [ATL-1599] [ATL-1416] Upgrade Theia to 1.18.0 (追記ここまで) Oct 4, 2021
# Conflicts:
#	arduino-ide-extension/package.json
#	yarn.lock
@fstasi fstasi merged commit da6b66f into main Oct 6, 2021
fstasi added a commit that referenced this pull request Oct 6, 2021
Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
@fstasi fstasi deleted the theia-upgrade branch October 7, 2021 07:55
@per1234 per1234 added topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project labels Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /