Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: support updates in lib/boards widget #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kittaakos wants to merge 3 commits into main
base: main
Choose a base branch
Loading
from show-updateble-badge-arduino

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 23, 2024

Motivation

This PR is identical to #1963 but not from a fork.

Moved from #1963 (comment):

Motivation

To enhance the libraries and the boards management.

Restore view state:

1963__restore_state.mp4
Show updates count on the side-bar:

1963__updates_count.mp4
New filter UX:

Screen Shot 2023年03月15日 at 21 36 11

Hover for libraries and platforms:

1963__hover.mp4

Change description

Other information

  • Thanks for the excellent work for @msujew's hover service in Theia. I have shamelessly copied his work as-is from the Theia repository. I wanted to exclude a Theia version update in this PR.
  • Thanks for the input for @nmzaheer spotting the incorrect library paragraph and sentence order months ago in his PR.

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Akos Kitta added 3 commits March 16, 2023 10:03 
 - can show badge with updates count,
 - better hover for libraries and platforms,
 - save/restore widget state (Closes #1398),
 - fixed `sentence` and `paragraph` order (Ref #1611)
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
 - do not render footer when scrolling
 - fix anchor word wrapping for long long links in the markdown
 - underline the link and change the cursor to pointer on hover
 - consider status-bar height when calculating hover top
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 23, 2024
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore filter in library and boards manager view between app stop/start

AltStyle によって変換されたページ (->オリジナル) /