-
-
Notifications
You must be signed in to change notification settings - Fork 515
GH-13: Forbid parallel LS-start command execution. #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From now on, a port change won't trigger LS start. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
I have fixed the LS start problem. Please review. There is a noteworthy change, the LS won't restart if the FQBN of the selected is the same as it was. For instance, when uploading to the MKR1000 on Windows, the port changes from COM5 to none, then COM6, finally back to COM5. The LS does not restart in such cases. Also, previously one could trigger an LS restart by reselecting the same board; this is not supported anymore. If we need a (force) restart action for whatever reason, we need to implement it as part of a separate task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me too. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Tested and working, nice job 👍
Thank you for the reviews 🙏
Uh oh!
There was an error while loading. Please reload this page.
From now on, a port change won't trigger LS start.
Closes #13.
Signed-off-by: Akos Kitta kittaakos@typefox.io