-
-
Notifications
You must be signed in to change notification settings - Fork 512
chore(deps): update vulnerable dependencies #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
the
topic: security
Related to the protection of user data
label
Nov 2, 2023
- Forced the resolution of `@babel/traverse@7.23.2` brought in by `@theia/cli`. (eclipse-theia/theia#13024) - Updated to `auth0-js@9.21.3` to transitively pull `crypto-js@4.2.0` in with the security fixes. GitHub Advisory Database refs: - GHSA-67hx-6x53-jw92 - GHSA-xwcq-pm8m-c4vf Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
dependabot
branch
from
November 2, 2023 08:57
f3f91da to
81f4326
Compare
rhpco
rhpco
approved these changes
Nov 2, 2023
@rhpco
rhpco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@per1234
per1234
added
topic: infrastructure
Related to project infrastructure
type: imperfection
Perceived defect in any part of project
labels
Nov 3, 2023
@kittaakos will verify:
- the correctness of the
@theia/cli(for@babel/traverse@7.23.2),- the cloud sketches feature in IDE2 (for
crypto-js@4.2.0),
It's working with 2.2.2-snapshot-f7c6da3.
francescospissu
francescospissu
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
To fix security issues.
Change description
@babel/traverse@7.23.2brought in by@theia/cli. (build(deps): bump @babel/traverse from 7.22.8 to 7.23.2 eclipse-theia/theia#13024 )auth0-js@9.21.3to transitively pullcrypto-js@4.2.0in with the security fixes.Other information
TODOs:
@kittaakos will verify:
@theia/cli(for@babel/traverse@7.23.2),crypto-js@4.2.0),@rhpco, please help with the security review. Thank you! If all works correctly, IDE2 will be down to zero security alerts.
Current behavior:
Expected behavior:
% yarn audit yarn audit v1.22.19 0 vulnerabilities found - Packages audited: 2046 ✨ Done in 2.26s.GitHub Advisory Database refs:
Upstream: eclipse-theia/theia#13024
Reviewer checklist