chore: update `electron` dependency + Node.js #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kittaakos merged 4 commits into main from update-infra

Sep 26, 2023

Merged

chore: update `electron` dependency + Node.js #2199

kittaakos merged 4 commits into main from update-infra

Sep 26, 2023

Conversation

@kittaakos

Copy link

Contributor

@kittaakos kittaakos commented Aug 29, 2023 •

edited

Loading

Motivation

Use Node.js 18+ and the latest Electron version for the build and runtime.

Change description

Other information

For reviewers:

The diff might seem overwhelming, but most is just text formatting. I suggest checking the commits individually to understand better how tiny this PR is.

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among the Pull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement topic: infrastructure topic: code labels

Aug 29, 2023

@kittaakos kittaakos self-assigned this

Aug 29, 2023

@kittaakos kittaakos mentioned this pull request

Aug 29, 2023

The changelog generation fails due to incompatible Node.js version #2200

Closed

3 tasks

@kittaakos kittaakos force-pushed the update-infra branch from 19b49ec to ed42b34 Compare

August 30, 2023 08:46

@kittaakos kittaakos changed the title ~~(削除) chore: update dependencies (削除ここまで)~~ (追記) chore: update electron dependency + Node.js (追記ここまで)

Aug 30, 2023

@kittaakos kittaakos requested review from davegarthsimpson and per1234

August 30, 2023 08:52

@kittaakos kittaakos marked this pull request as ready for review

August 30, 2023 08:52

per1234

per1234 previously requested changes

Aug 31, 2023

View reviewed changes

Copy link

Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the Node version in these workflows:

arduino-ide/.github/workflows/compose-full-changelog.yml

Line 11 in ed42b34

NODE_VERSION: 16.x

arduino-ide/.github/workflows/themes-weekly-pull.yml

Line 12 in ed42b34

NODE_VERSION: 16.x

.prettierignore Outdated Show resolved Hide resolved

.prettierrc.json Show resolved Hide resolved

Akos Kitta added 4 commits

September 1, 2023 10:21


 chore: update prettier config

00d5dcb

narrow the `resources` folder constraint in
the .gitignore
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>


 chore: format resources 💄

22c1cf4

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>


 chore: use Node.js >=18.17.0

b1bf3be

remove `msvs_version` npm config on win32
Ref: nodejs/node-gyp#2822
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>


 chore(deps): update electron@25.5.0

62736fa

 - Update to `electron-builder@24.6.3`.
 - Fix obsolete electron security section in the development docs.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

@kittaakos kittaakos force-pushed the update-infra branch from ed42b34 to 62736fa Compare

September 1, 2023 08:27

kittaakos

kittaakos commented

Sep 1, 2023

View reviewed changes

docs/internal/Ubuntu.md

### Building and start the app from the sources on Ubuntu Linux

Tested and verified on Ubuntu 18.04.4. The source will be checked out to `~/dev/git/arduino-ide`.

Tested and verified on Ubuntu 22.04. The source will be checked out to `~/dev/git/arduino-ide`.

Copy link

Contributor Author

@kittaakos kittaakos Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chicken-egg problem: the main still does not support Node.js 18+. Here is what should work. The git checkout part differs

#!/bin/bash -i
sudo apt update \
&& sudo apt install --no-install-recommends --yes \
 git \
 gcc \
 curl \
 make \
 python3 \
 pkg-config \
 libx11-dev \
 libxkbfile-dev \
 build-essential \
 libsecret-1-dev \
&& wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash \
&& source ~/.bashrc \
&& nvm install 18.17 \
&& nvm use 18.17 \
&& nvm alias default 18.17 \
&& curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - \
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list \
&& sudo apt update && sudo apt install --no-install-recommends yarn \
&& mkdir -p ~/dev/git/ \
&& rm -rf ~/dev/git/arduino-ide \
&& git clone https://github.com/arduino/arduino-ide.git ~/dev/git/arduino-ide \
&& git -C ~/dev/git/arduino-ide checkout origin/update-infra -b update-infra \
&& yarn --cwd ~/dev/git/arduino-ide \
&& yarn --cwd ~/dev/git/arduino-ide/electron-app rebuild \
&& yarn --cwd ~/dev/git/arduino-ide build \
&& yarn --cwd ~/dev/git/arduino-ide start

@kittaakos kittaakos requested a review from per1234

September 1, 2023 08:34

@kittaakos kittaakos mentioned this pull request

Sep 1, 2023

chore(deps): update to theia@1.41.0 #2211

Merged

4 tasks

@kittaakos

Copy link

Contributor Author

kittaakos commented Sep 12, 2023

Please review. Thank you!

davegarthsimpson

davegarthsimpson approved these changes

Sep 14, 2023

View reviewed changes

Copy link

Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all makes sense, I do not see any issues.

@per1234 per1234 dismissed their stale review

September 21, 2023 05:52

whatever

@kittaakos kittaakos merged commit ed2d8ad into main

Sep 26, 2023

@kittaakos kittaakos deleted the update-infra branch

September 26, 2023 08:06

@per1234 per1234 mentioned this pull request

Oct 28, 2023

Error message not displayed when Boards Manager installation fails with "UNKNOWN" status code #2269

Open

3 tasks

Labels

topic: code topic: infrastructure type: enhancement

3 participants

@kittaakos @per1234 @davegarthsimpson

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: update `electron` dependency + Node.js #2199

chore: update `electron` dependency + Node.js #2199

Uh oh!

Conversation

@kittaakos kittaakos commented Aug 29, 2023 •

edited

Loading

Uh oh!

Motivation

Change description

Other information

Reviewer checklist

Uh oh!

@per1234 per1234 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

@kittaakos kittaakos Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

kittaakos commented Sep 12, 2023

Uh oh!

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

chore: update electron dependency + Node.js #2199

chore: update electron dependency + Node.js #2199

Uh oh!

Conversation

@kittaakos kittaakos commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Change description

Other information

Reviewer checklist

Uh oh!

@per1234 per1234 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

@kittaakos kittaakos Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

kittaakos commented Sep 12, 2023

Uh oh!

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: update `electron` dependency + Node.js #2199

chore: update `electron` dependency + Node.js #2199

@kittaakos kittaakos commented Aug 29, 2023 •

edited

Loading