-
-
Notifications
You must be signed in to change notification settings - Fork 515
test: use raw core index-update for the tests
#2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It should make integration tests more resilient on the Windows CI. From now on, tests are not starting a daemon to initialize the `directories.data` folder for the test suites but rely on the raw command. It is required to avoid spawning the discovery processes, which cannot be terminated on Windows while the daemon is up and running. Closes #2059 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really possible to test this, but the code looks good to me 👍
It's not really possible to test this, but the code looks good to me 👍
Thanks! I will keep an eye on the nightly builds. If the scheduled builds are back, we have fixed the problem.
-
https://github.com/arduino/arduino-ide/actions/runs/4964767692:
Screen Shot 2023年05月13日 at 12 47 17 -
A few more green scheduled builds:
Screen Shot 2023年05月16日 at 10 54 33
Motivation
It should make integration tests more resilient on the Windows CI.
From now on, tests are not starting a daemon to initialize the
directories.datafolder for the test suites but rely on the raw command. It is required to avoid spawning the discovery processes, which cannot be terminated on Windows while the daemon is up and running.Steps to verify (probably not possible as the review 😕):
Change description
Other information
Closes #2059
Reviewer checklist