-
-
Notifications
You must be signed in to change notification settings - Fork 515
ATL-1063: Integrated search in workspace into IDE #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ubidefeo
commented
Mar 11, 2021
hi Akos
This PR integrates Theia's default Search view into the IDE2.
From now on, the Search view is part of the default layout, so when the user opens a new sketch, the Search view (with the magnifier icon. the monitor widget has a similar icon 😕) should be visible on the left sidebar.
This is a welcome addition to the IDE. Don't worry about the icon, we'll have to go through a final polishing of the theme at some point
This PR changes the order of the widgets on the left: Board Manager, Lib Manager, Debug, Explorer (this is hidden), Search, and Outline is the order. Then the rest of the views, if any.
I toggled the Explorer and it comes before the Debugger
Screenshot 2021年03月11日 at 22 08 38
This PR changes the default width of the sidebar views. When you open the view, it should require 200px width. It was 100px before. I thought increasing the width is a good thing, whenever I open a view, I have to change the horizontal dimension every time manually. What do you think?
200px is a better option. I ran into the same issue you did and had to manually resize.
It was gonna turn into a task at some point :D
I'm fine with everything except the position of the Explorer if toggled. I'd place this at the very top, VS Code style ;)
Explorer if toggled. I'd place this at the very top, VS Code style ;)
👍 Even better. Thank you for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, here I am again being a pain with my dirty sketches.
- File > Preferences
- Uncheck the box next to "Auto save".
- Click the "OK" button.
- Add the following text to a sketch:
foobar - Click the search icon in the sidebar.
- In the "Search" field", type
bar - Click the downward pointing triangle button at the bottom left corner of "Search" field to reveal the "Replace" field.
- In the "Replace" field", type
baz- in the results section, the expected "foo(削除) bar (削除ここまで)baz" is shown. - Click "foo
(削除) bar (削除ここまで)baz" to open the "Replace Preview" view in the editor. - the right side editor pane only shows "baz", rather than the expected "foobaz"
84459f9 to
58d0a2a
Compare
I have fixed it in Theia and patched the IDE2 for the time being. Please review.
- Reordered the sidebar views. - Increased the default sidebar width. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
58d0a2a to
6255ca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great now. Thanks Akos!
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does:
Searchview into the IDE2.Searchview is part of the default layout, so when the user opens a new sketch, theSearchview (with the magnifier icon. the monitor widget has a similar icon 😕) should be visible on the left sidebar.Board Manager,Lib Manager,Debug,Explorer(this is hidden),Search, andOutlineis the order. Then the rest of the views, if any.Please review. Thank you!