-
-
Notifications
You must be signed in to change notification settings - Fork 512
ATL-653: Added error handling for core/lib install #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
per1234
per1234
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out and it's a very nice improvement. Thanks Akos!
fstasi
fstasi
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good
ubidefeo
commented
Mar 12, 2021
🚀
@kittaakos
kittaakos
deleted the
atl-653--handle-core-install-error-gracefully
branch
March 12, 2021 08:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on, we toast an error message and update the Arduino output channel if the platform/lib installation has failed for whatever reason.
I tested the changeset with the following 3rd party cores:
In-action:
screencast.2021年03月10日.13-19-03.mp4
Before this change: there was no indication of the installation failure.
Signed-off-by: Akos Kitta kittaakos@typefox.io