Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: new UX for the boards/library manager widget #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 1 commit into main from #19
Mar 15, 2023
Merged

feat: new UX for the boards/library manager widget #1927

kittaakos merged 1 commit into main from #19
Mar 15, 2023

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 1, 2023 •
edited by per1234
Loading

Motivation

Change description

TODOs:

19_01.mp4
19_02.mp4
  • Library/Boards Manager offers already installed release when it is the only one #781
    • Open the libraries manager widget,
    • Search for Arduino Uno WiFi Dev Ed Library,
    • If the library is installed, uninstall it,
    • Verify that only 0.0.3 is available in the select,
    • Click on the Install button,
    • Library is installed, but the select still shows 0.0.3 version, and the button shows Remove instead of Install,
    • Click on ..., and the context menu shows Remove. Remove from the context menu is always visible when the library is installed. It does not depend on the button's state.
781.mp4
1607.mp4
1679.mp4
1707.mp4
1924_01.mp4
  • When changing the version of a lib, all other versions reset to the default:
1924_02.mp4
  • When installing or uninstalling a library, the version selection of all libraries reset to the default.
1924_03.mp4
1924_04.mp4
1941.mp4

Other information

  • The Install/Update/Remove button is disabled when installing, updating, or removing a library.
other_01.mp4
  • Colors work well with all three supported themes.
other_02.mp4
  • When a library is installed with at least one example, the Examples submenu is available from the ... context menu.
other_03.mp4
  • Can open More info from the context menu.
  • Can select another version from the context menu. The menu is not visible when there is only one version available.

Screen Shot 2023年03月09日 at 12 21 53

Reviewer checklist

Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1707
Closes #1924
Closes #1941

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 1, 2023
@kittaakos kittaakos self-assigned this Mar 1, 2023
@kittaakos kittaakos changed the title (削除) feat: new UX for the boards/library manager widgets (削除ここまで) (追記) feat: new UX for the boards/library manager widget (追記ここまで) Mar 2, 2023
@kittaakos kittaakos force-pushed the #19 branch 9 times, most recently from 14e3476 to 1d2de77 Compare March 9, 2023 07:44
@kittaakos kittaakos marked this pull request as ready for review March 9, 2023 11:22
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

Copy link

91volt commented Mar 13, 2023 •
edited
Loading

Thanks @kittaakos, great work! I have only 2 points (not critical imho)

  1. I believe it would be beneficial to keep the "More info" link within the card, as it provides users with an easy and accessible way to access additional information: with the introduction of the description truncation for a more compact layout, having this link easily discoverable would be especially valuable.
    Proposed solution:
    image

  2. Additionally, although it wasn't in the proposed design, I think it would be better to show the contextual menu icons when the user hovers over the card, similar to how we currently use it for sketches listed in the sketchbook sidebar panel. This would provide users with a cleaner card while them are not interacting with the content. What are your thoughts on this?

Registrazione.schermo.2023年03月13日.alle.10.38.26.mov
per1234 reacted with heart emoji

Copy link
Contributor Author

  1. I believe it would be beneficial to keep the "More info" link within the card,

It's a bug. I do not know how I missed it. Thanks!

2. I think it would be better to show the contextual menu icons when the user hovers over the card

Sure. I wanted to do it as you're requesting now, but it was different in the design.
91volt reacted with thumbs up emoji

Copy link
Contributor Author

I have only 2 points (not critical imho)

Thanks for the feedback. Both issues should be fixed.
Missing More info:
Screen Shot 2023年03月13日 at 11 19 50

Screen Shot 2023年03月13日 at 10 57 14

Show ... context menu on hover:

19.mp4 

Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1697
Closes #1707
Closes #1924
Closes #1941
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos merged commit 2aad0e3 into main Mar 15, 2023
@kittaakos kittaakos deleted the #19 branch March 15, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

AltStyle によって変換されたページ (->オリジナル) /