-
-
Notifications
You must be signed in to change notification settings - Fork 515
fix: no unnecessary tree update on mouse over/out #1922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1766 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Feb 27, 2023
per1234
per1234
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified it fixes #1766 and doesn't introduce any regressions. Thanks Akos!
AlbyIanna
AlbyIanna
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks Akos!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Removed unnecessary tree widget update and scroll to node action on mouse over/leave events.
Change description
Other information
Follow the steps from the issue description; they're excellent. You experience no unnecessary scrolling in the tree. You verify that the inline actions, such
...for the context menu and pull/push in the cloud tree are rendered and functional when you hover over a node representing a sketch folder.Closes #1766
Reviewer checklist