-
-
Notifications
You must be signed in to change notification settings - Fork 512
fix: start the LS with the board specific settings #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
topic: language server
Related to the Arduino Language Server
labels
Jan 10, 2023
AlbyIanna
AlbyIanna
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected for me. I just left a remark about a little typo in a comment
@kittaakos
kittaakos
force-pushed
the
#1029
branch
from
January 11, 2023 08:50
12d1573 to
341855a
Compare
restart the LS when board settings of the running LS has changed Closes #1029 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1029
branch
from
January 16, 2023 08:41
341855a to
dd0b127
Compare
per1234
per1234
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Akos!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
The Arduino Language features must incorporate the settings of the selected board.
Change description
From now on, the IDE2 starts the LS with the FQBN decorated with the settings. Open the DevTools and check the console if you're interested:
Also, from now on, the LS restarts when the user changes the board settings of the currently running LS.
Steps to verify:
Tools>USB TypefromSerialtoRaw HIDand vice versa. This can be verified with thetextDocument/hoverin the editor.In action:
1029.mp4
Other information
Closes #1029
Reviewer checklist