-
-
Notifications
You must be signed in to change notification settings - Fork 515
fix: remote sketch creation if tree is not active #1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Nov 28, 2022
Closes #1715 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1715
branch
from
November 28, 2022 09:00
1e72056 to
13d2ec5
Compare
@kittaakos
kittaakos
changed the title
(削除) fix: remote sketch creation if view is not active (削除ここまで)
(追記) fix: remote sketch creation if tree is not active (追記ここまで)
Nov 28, 2022
per1234
per1234
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes #1715
Thanks Akos!
AlbyIanna
AlbyIanna
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
@per1234
per1234
added
the
topic: cloud
Related to Arduino Cloud and cloud sketches
label
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
The new remote sketch creation must work from
File>New Remote Sketchor Ctrl/Cmd+Alt+N when a user is logged in, but the Remote Sketchbook is not the active tree inside the Sketchbook view.Change description
New API to access all widgets besides the currently selected one.
Other information
Closes #1715
Reviewer checklist