-
-
Notifications
You must be signed in to change notification settings - Fork 512
#572 Can send message to the monitor with Enter
#1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed the required `Ctrl/Cmd` modifier. Closes #572 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
If required, I can make this configurable with a preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works perfectly. Thanks Akos!
it should work with Numpad Enter but it would be great if somebody could verify it
I tried it using the Enter key on a couple of different numpads and it worked fine. However, from what I could see using tools like this, it was no different from the standard Enter key, so I'm not sure whether I was able to provide an effective test.
I can make this configurable with a preference.
I haven't found any use case where Ctrl+Enter provided any benefit over Enter alone, and I didn't receive any complaints about the Enter trigger over the years of supporting Arduino IDE 1.x, so I don't see any need to make it configurable.
The switch to Enter won't be a breaking change for those who have already become accustomed to Ctrl+Enter because that trigger will still work as a matter of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Can send message to monitor with Enter instead of Ctrl/⌘+Enter.
I checked the Theia code, it should work with Numpad Enter but it would be great if somebody could verify it. Thank you!
Change description
Closes #572
Other information
Reviewer checklist