-
-
Notifications
You must be signed in to change notification settings - Fork 515
Error message if upload is not possible #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me.
I am not familiar with the board user fields logic, maybe we should change
if (this.boardRequiresUserFields && !this.cachedUserFields.has(key)) {
to
if (this.boardRequiresUserFields && key && !this.cachedUserFields.has(key)) {
@ubidefeo
ubidefeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
arduino-ide-extension/src/browser/contributions/contribution.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Francesco!
Motivation
If the user presses the upload button and no board is selected, a message should appear warning what went wrong while uploading. Since verify takes place before upload, the same message that is given when the user tries to compile a sketch without selecting a board should be shown. On the other hand, this message is not very clear, so it should be updated.
Change description
Communicate to user when upload is impossible due to no board selection.
Make error message from compiling without board selected more user friendly.
Other information
Closes #845.
Closes #62.
This fix depends on the changes made here: arduino/arduino-cli#1848. Without it it is not possible to verify that #62 is resolved.
Reviewer checklist