Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

#1142 Handle missing core when getting board user fields #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 1 commit into main from #1142
Aug 18, 2022
Merged

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Aug 16, 2022 •
edited
Loading

Motivation

Handles the SupportedUserFieldsRequest gracefully when the board's platform is not installed.

Change description

To verify:

  • make sure you do not have the board for the RP2040 installed,
  • start the IDE2 (you can also trace the error log or open the dev tools to see the client error),
  • select the RP2040,
  • you should see no errors as described in Error when calling getBoardUserFields from CLI #1142

Other information

Closes #1142

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)
 

Closes #1142
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 16, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Windows and Linux and it is working fine for me and fixes #1142.

Thanks Akos!

@kittaakos kittaakos changed the title (削除) Handle missing core when getting board user fields (削除ここまで) (追記) #1142 Handle missing core when getting board user fields (追記ここまで) Aug 17, 2022
@kittaakos kittaakos merged commit d674ab9 into main Aug 18, 2022
@kittaakos kittaakos deleted the #1142 branch August 18, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

No one assigned

Labels

topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when calling getBoardUserFields from CLI

AltStyle によって変換されたページ (->オリジナル) /