-
-
Notifications
You must be signed in to change notification settings - Fork 515
Register custom themes after the monaco theme init #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kittaakos
commented
Jul 27, 2022
Please update from the main. Thank you!
The changes should contain the app config provider customization. See here. The content of the electron-app/patch/frontend/index.js and electron/build/patch/frontend/index.js modules must be the same.
97e1b1f to
0d84164
Compare
@kittaakos
kittaakos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patched index.js modules are not identical.
0d84164 to
f448065
Compare
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
f448065 to
86c5fb1
Compare
@kittaakos
kittaakos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@davegarthsimpson
davegarthsimpson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
If the Arduino custom theme registration happens before the restoration of the existing monaco themes, then any custom theme changes will be ignored.
Change description
We need to add a patch introduces a static deferred promise in the monaco-theming service that will be resolved when the restoration is ready.
After upgrading to Theia 1.27.0, this patch should be superflous.
Other information
The credit for this solution goes to @kittaakos
Reviewer checklist