-
-
Notifications
You must be signed in to change notification settings - Fork 137
Test to ascii #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to ascii #206
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (e9d4d01) to head (1e6d3f1).
Additional details and impacted files
@@ Coverage Diff @@ ## master #206 +/- ## ======================================= Coverage 95.61% 95.61% ======================================= Files 14 14 Lines 1048 1048 ======================================= Hits 1002 1002 Misses 46 46
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
60b64bc to
1e6d3f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Compiling of the test cases under C++20 is not terribly relevant to us, but since it also works w/ C++11 (under which our CI tests run) AND because its test code I'll allow this in.
Fix for #197 by removing undef of _GNU_SOURCE.
Change includes PR #205 so I can run the test suite reliably.