-
Notifications
You must be signed in to change notification settings - Fork 20
fix: UnoQ support for I2C priority function #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
facchinm
merged 1 commit into
arduino-libraries:main
from
dido18:fix-increase-priority-unoq
Oct 16, 2025
Merged
fix: UnoQ support for I2C priority function #42
facchinm
merged 1 commit into
arduino-libraries:main
from
dido18:fix-increase-priority-unoq
Oct 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on UNOQ
#include <Modulino.h>
#include "Arduino_LED_Matrix.h"
Arduino_LED_Matrix matrix;
ModulinoButtons buttons;
uint8_t shades[104] = {
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3,
4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4,
5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,
6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6,
7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7,
};
void setup() {
Modulino.begin(Wire1);
buttons.begin();
matrix.begin();
}
void loop() {
if (buttons.update()) {
if (buttons.isPressed('A')) {
matrix.clear();
}
if (buttons.isPressed('B')) {
matrix.draw(shades);
}
}
}
Tested on UNO R4 with this sketch
#include "Arduino_LED_Matrix.h" // Include the LED_Matrix library
#include "frames.h" // Include a header file containing some custom icons
#include <Modulino.h>
ModulinoButtons buttons;
ArduinoLEDMatrix matrix; // Create an instance of the ArduinoLEDMatrix class
void setup() {
Serial.begin(115200); // Initialize serial communication at a baud rate of 115200
matrix.begin(); // Initialize the LED matrix
Modulino.begin();
buttons.begin();
}
void loop() {
if (buttons.update()) {
if (buttons.isPressed('A')) {
matrix.loadFrame(LEDMATRIX_HEART_BIG);
} else if (buttons.isPressed("B")) {
matrix.clear();
}
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
Fix compilation failure for UnoQ when both Modulino and Arduino_LED_Matrix libraries are included.
How to reproduce
Modulino 0.6.0arduino:zephyr 0.51.0Example sketch that triggers the error:
Error
Root Cause
Modulino.cpp incorrectly handles the conditional logic for defining __increaseI2CPriority.
When Arduino_LED_Matrix.h is included but ARDUINO_UNOR4_WIFI is not defined (e.g., compiling for UnoQ), neither branch provides a definition for the function, resulting in an undefined reference.
Fix
Ensure that there is always at least one definition of
__increaseI2CPriority. If UnoQ the void definition is added.