Add `getDirection()` support to `ModulinoKnob` and example ⚡ #34

✅ getDirection() returns 1 for clockwise, -1 for counter-clockwise, and 0 when no movement is detected (debounced).
🧠 Internal debouncing is handled via DEBOUNCE_DELAY to avoid noisy reads.
🛠️ The begin() logic now initializes internal state (_lastPosition, _lastDebounceTime) accordingly.
🧪 The basic example sketch has been updated to demonstrate the use of getDirection().

🔁 Related Work

✔️ Brings over logic and fixes from PR ModulinoKnob: report error and not last valid _pressed if read() fails #20 , adapting them for this implementation.
🔗 Closes issue Add function for Modulino Knob to detect direction #9 by properly implementing movement direction detection and showing how it can be used in real code, as discussed in this comment.

Fixed #9

AntonioBerna added 5 commits

April 30, 2025 03:41

@AntonioBerna


 feat(buttons): allow isPressed() to accept 'A', 'B', 'C' as input

53c079c

Added support for character and string-based input to `isPressed()` in `ModulinoButtons`,
so it now accepts both index (0–2) and letter identifiers (`'A'`, `'B'`, `'C'`) matching
the physical button labeling.
Closes arduino-libraries#3

@AntonioBerna


 Update example to document support for both numeric and letter indice...

59aef64

...s ♻️

@AntonioBerna


 Add getDirection() support to ModulinoKnob and example ⚡

e53f803

@AntonioBerna


 Fix: 🔥

9a2a9cf

@AntonioBerna


 Fix: restore files 🔥

3d48585

@per1234 per1234 added the enhancement label

May 2, 2025

@leonardocavagnis leonardocavagnis self-requested a review

May 8, 2025 14:08

leonardocavagnis

leonardocavagnis requested changes

May 8, 2025

View reviewed changes

Copy link

Contributor

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!
Please, take a look to my review. Minor fixes

.gitignore Outdated

Copy link

Contributor

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.
It is already included in the PR #33

examples/Modulino_Buttons/Buttons_Basic/Buttons_Basic.ino

Copy link

Contributor

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this file :)
this modifies doesn't add any feature to the PR

examples/Modulino_Knob/Knob_Basic/Knob_Basic.ino Outdated Show resolved Hide resolved

src/Modulino.h

}

return ret;

}

int16_tget() {

Copy link

Contributor

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it.
it is already included in the PR #32

src/Modulino.h Outdated

if (res == false) {

return 0;

}

get(buf);

Copy link

Contributor

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here
it is already included in the PR #32

AntonioBerna added 3 commits

May 8, 2025 17:04

@AntonioBerna


 Minor fixes ♻️

c70097d

@AntonioBerna


 Update API docs ♻️

66200f1

@AntonioBerna


 Update API docs ♻️

cff95ab

@AntonioBerna

Copy link

Contributor Author

AntonioBerna commented May 8, 2025

@leonardocavagnis I apologize for creating problems with the files but I had accidentally merged the changes of PR #33 into the main branch of the Modulino repository fork and when I created the branch for PR #34 the changes were automatically added.

With commit 66200f1 this PR is affected to pull request is merged indirectly or is still processing updates.

For this reason with commit cff95ab everything should be fixed correctly.

I remain waiting for further developments. Enjoy 🎉

@AntonioBerna AntonioBerna requested a review from leonardocavagnis

May 8, 2025 16:49

@leonardocavagnis


 Update examples/Modulino_Knob/Knob_Basic/Knob_Basic.ino

812cd95

leonardocavagnis

leonardocavagnis approved these changes

May 9, 2025

View reviewed changes

Copy link

Contributor

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@leonardocavagnis leonardocavagnis merged commit 3c36732 into arduino-libraries:main

May 9, 2025

2 checks passed

Labels

enhancement

3 participants

@AntonioBerna @leonardocavagnis @per1234

Add getDirection() support to ModulinoKnob and example ⚡ #34

Add getDirection() support to ModulinoKnob and example ⚡ #34

Uh oh!

Conversation

@AntonioBerna AntonioBerna commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

🔁 Related Work

Uh oh!

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

Uh oh!

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

Uh oh!

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

Uh oh!

@leonardocavagnis leonardocavagnis May 8, 2025

Choose a reason for hiding this comment

Uh oh!

AntonioBerna commented May 8, 2025

Uh oh!

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add `getDirection()` support to `ModulinoKnob` and example ⚡ #34

Add `getDirection()` support to `ModulinoKnob` and example ⚡ #34

@AntonioBerna AntonioBerna commented May 1, 2025 •

edited

Loading