Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Support additional headers in WebSocketClient #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MSchmidt wants to merge 3 commits into arduino-libraries:master
base: master
Choose a base branch
Loading
from MSchmidt:master

Conversation

@MSchmidt
Copy link

@MSchmidt MSchmidt commented May 1, 2021

Allows users of this library to add headers to the opening WebSocket request.

Example usage:

char* socketHeaders[2][2];
socketHeaders[0][0] = "Cookie";
socketHeaders[0][1] = "mycookie=withValue";
socketHeaders[1][0] = "Origin";
socketHeaders[1][1] = "http://www.example.com";
client.begin("/socket", socketHeaders, 2);

Copy link

CLAassistant commented May 1, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented May 1, 2021

Memory usage change @ 4a66056

Board flash % RAM for global variables %
arduino:samd:mkr1000 🔺 0 - +40 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BasicAuthGet
flash		 % examples/BasicAuthGet
RAM for global variables		 % examples/CustomHeader
flash		 % examples/CustomHeader
RAM for global variables		 % examples/DweetGet
flash		 % examples/DweetGet
RAM for global variables		 % examples/DweetPost
flash		 % examples/DweetPost
RAM for global variables		 % examples/HueBlink
flash		 % examples/HueBlink
RAM for global variables		 % examples/PostWithHeaders
flash		 % examples/PostWithHeaders
RAM for global variables		 % examples/SimpleDelete
flash		 % examples/SimpleDelete
RAM for global variables		 % examples/SimpleGet
flash		 % examples/SimpleGet
RAM for global variables		 % examples/SimpleHttpExample
flash		 % examples/SimpleHttpExample
RAM for global variables		 % examples/SimplePost
flash		 % examples/SimplePost
RAM for global variables		 % examples/SimplePut
flash		 % examples/SimplePut
RAM for global variables		 % examples/SimpleWebSocket
flash		 % examples/SimpleWebSocket
RAM for global variables		 %
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 40 0.02 0 0.0
Click for full report CSV 
Board,examples/BasicAuthGet<br>flash,%,examples/BasicAuthGet<br>RAM for global variables,%,examples/CustomHeader<br>flash,%,examples/CustomHeader<br>RAM for global variables,%,examples/DweetGet<br>flash,%,examples/DweetGet<br>RAM for global variables,%,examples/DweetPost<br>flash,%,examples/DweetPost<br>RAM for global variables,%,examples/HueBlink<br>flash,%,examples/HueBlink<br>RAM for global variables,%,examples/PostWithHeaders<br>flash,%,examples/PostWithHeaders<br>RAM for global variables,%,examples/SimpleDelete<br>flash,%,examples/SimpleDelete<br>RAM for global variables,%,examples/SimpleGet<br>flash,%,examples/SimpleGet<br>RAM for global variables,%,examples/SimpleHttpExample<br>flash,%,examples/SimpleHttpExample<br>RAM for global variables,%,examples/SimplePost<br>flash,%,examples/SimplePost<br>RAM for global variables,%,examples/SimplePut<br>flash,%,examples/SimplePut<br>RAM for global variables,%,examples/SimpleWebSocket<br>flash,%,examples/SimpleWebSocket<br>RAM for global variables,%
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,40,0.02,0,0.0

Copy link

Memory usage change @ a142ab2

Board flash % RAM for global variables %
arduino:samd:mkr1000 🔺 0 - +40 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BasicAuthGet
flash		 % examples/BasicAuthGet
RAM for global variables		 % examples/CustomHeader
flash		 % examples/CustomHeader
RAM for global variables		 % examples/DweetGet
flash		 % examples/DweetGet
RAM for global variables		 % examples/DweetPost
flash		 % examples/DweetPost
RAM for global variables		 % examples/HueBlink
flash		 % examples/HueBlink
RAM for global variables		 % examples/PostWithHeaders
flash		 % examples/PostWithHeaders
RAM for global variables		 % examples/SimpleDelete
flash		 % examples/SimpleDelete
RAM for global variables		 % examples/SimpleGet
flash		 % examples/SimpleGet
RAM for global variables		 % examples/SimpleHttpExample
flash		 % examples/SimpleHttpExample
RAM for global variables		 % examples/SimplePost
flash		 % examples/SimplePost
RAM for global variables		 % examples/SimplePut
flash		 % examples/SimplePut
RAM for global variables		 % examples/SimpleWebSocket
flash		 % examples/SimpleWebSocket
RAM for global variables		 %
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 40 0.02 0 0.0
Click for full report CSV 
Board,examples/BasicAuthGet<br>flash,%,examples/BasicAuthGet<br>RAM for global variables,%,examples/CustomHeader<br>flash,%,examples/CustomHeader<br>RAM for global variables,%,examples/DweetGet<br>flash,%,examples/DweetGet<br>RAM for global variables,%,examples/DweetPost<br>flash,%,examples/DweetPost<br>RAM for global variables,%,examples/HueBlink<br>flash,%,examples/HueBlink<br>RAM for global variables,%,examples/PostWithHeaders<br>flash,%,examples/PostWithHeaders<br>RAM for global variables,%,examples/SimpleDelete<br>flash,%,examples/SimpleDelete<br>RAM for global variables,%,examples/SimpleGet<br>flash,%,examples/SimpleGet<br>RAM for global variables,%,examples/SimpleHttpExample<br>flash,%,examples/SimpleHttpExample<br>RAM for global variables,%,examples/SimplePost<br>flash,%,examples/SimplePost<br>RAM for global variables,%,examples/SimplePut<br>flash,%,examples/SimplePut<br>RAM for global variables,%,examples/SimpleWebSocket<br>flash,%,examples/SimpleWebSocket<br>RAM for global variables,%
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,40,0.02,0,0.0

Copy link

ddaydd commented Apr 2, 2022

Hello, can you merge this ? I need additional headers in WebSocketClient :p
MSchmidt reacted with rocket emoji MSchmidt reacted with eyes emoji

Copy link

Memory usage change @ a8ccd15

Board flash % RAM for global variables %
arduino:samd:mkr1000 🔺 0 - +40 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BasicAuthGet
flash		 % examples/BasicAuthGet
RAM for global variables		 % examples/CustomHeader
flash		 % examples/CustomHeader
RAM for global variables		 % examples/DweetGet
flash		 % examples/DweetGet
RAM for global variables		 % examples/DweetPost
flash		 % examples/DweetPost
RAM for global variables		 % examples/HueBlink
flash		 % examples/HueBlink
RAM for global variables		 % examples/PostWithHeaders
flash		 % examples/PostWithHeaders
RAM for global variables		 % examples/SimpleDelete
flash		 % examples/SimpleDelete
RAM for global variables		 % examples/SimpleGet
flash		 % examples/SimpleGet
RAM for global variables		 % examples/SimpleHttpExample
flash		 % examples/SimpleHttpExample
RAM for global variables		 % examples/SimplePost
flash		 % examples/SimplePost
RAM for global variables		 % examples/SimplePut
flash		 % examples/SimplePut
RAM for global variables		 % examples/SimpleWebSocket
flash		 % examples/SimpleWebSocket
RAM for global variables		 %
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 40 0.02 0 0.0
Click for full report CSV 
Board,examples/BasicAuthGet<br>flash,%,examples/BasicAuthGet<br>RAM for global variables,%,examples/CustomHeader<br>flash,%,examples/CustomHeader<br>RAM for global variables,%,examples/DweetGet<br>flash,%,examples/DweetGet<br>RAM for global variables,%,examples/DweetPost<br>flash,%,examples/DweetPost<br>RAM for global variables,%,examples/HueBlink<br>flash,%,examples/HueBlink<br>RAM for global variables,%,examples/PostWithHeaders<br>flash,%,examples/PostWithHeaders<br>RAM for global variables,%,examples/SimpleDelete<br>flash,%,examples/SimpleDelete<br>RAM for global variables,%,examples/SimpleGet<br>flash,%,examples/SimpleGet<br>RAM for global variables,%,examples/SimpleHttpExample<br>flash,%,examples/SimpleHttpExample<br>RAM for global variables,%,examples/SimplePost<br>flash,%,examples/SimplePost<br>RAM for global variables,%,examples/SimplePut<br>flash,%,examples/SimplePut<br>RAM for global variables,%,examples/SimpleWebSocket<br>flash,%,examples/SimpleWebSocket<br>RAM for global variables,%
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,40,0.02,0,0.0

Copy link
Author

MSchmidt commented Apr 2, 2025

Could this be merged? No issues as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /