This repository was archived by the owner on Apr 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Correct arduino compile command creation with unstripped parameters #103
Merged
MrPointer
merged 1 commit into
arduino-cmake:master
from
wgrs33:bugfix/correct-makefile-creation
Apr 17, 2023
Merged
Correct arduino compile command creation with unstripped parameters #103
MrPointer
merged 1 commit into
arduino-cmake:master
from
wgrs33:bugfix/correct-makefile-creation
Apr 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPointer
MrPointer
approved these changes
Apr 17, 2023
I don't know if you missed the notice on the project's readme, but this is not maintained anymore, for over 3 years actually 😅
Regardless, your changes are small enough and LGTM, so I'll merge, but after that, I'll archive the repo to remove confusion.
Thanks for the support, the effort, and mostly - For understanding.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring a project by cmake, some
flags.makecan contain unstripped newlines and extra spaces. This fix corrects it. Fix tested of Ubuntu 22.04.Before:
After: