-
Notifications
You must be signed in to change notification settings - Fork 725
[CI] Limit Torch to older than 2.8 #2591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpeiz
junpeiz
approved these changes
Sep 5, 2025
noobsiecoder
pushed a commit
to noobsiecoder/coremltools
that referenced
this pull request
Sep 10, 2025
Co-authored-by: yifan_shen3 <yifan_shen3@apple.com>
junpeiz
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Fix Issue #2583: Dynamic padding in torch.nn.functional.pad Modified _array_construct to handle dynamic padding values: Creates proper Var objects using mb.concat instead of Python lists + Fixes AttributeError when converting models with x.size(-1) padding * limit torch to older than 2.8 for now (#2591) Co-authored-by: yifan_shen3 <yifan_shen3@apple.com> * Add RMSNorm operator support for PyTorch to CoreML conversion (#2585) (#2592) * Add RMSNorm operator support for PyTorch to CoreML conversion (#2585) * formatted code * handles FP16 overflow for RMSNorm operation * handle dynamic padding w/o breaking legacy code --------- Co-authored-by: Yifan Shen <yifanshensz@jhu.edu> Co-authored-by: yifan_shen3 <yifan_shen3@apple.com>
This was referenced Sep 16, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Torch has released 2.8, but we support up to 2.7.1 for now. Before we upgrade coremltools to be compatible with torch 2.8, let us limit torch < 2.8 in CI for now
CI ✅ https://gitlab.com/coremltools1/coremltools/-/commit/463b494215a5f6f9ef73e913e8d60a25fe8c472d/pipelines