-
Notifications
You must be signed in to change notification settings - Fork 7
Added EventDispatcher as dependency #56
Conversation
@mmoreram
mmoreram
commented
Sep 17, 2018
- Deleted composer.lock from repository
- Deleted composer.lock from repository
cv65kr
commented
Sep 17, 2018
@mmoreram The same problem is with Apisearch\Url\UrlBuilder also require symfony/routing.
I think Events and UrlBuilder should be moved into apisearch-bundle. Client should be pure and universal without additional compontents. WDYT?
@cv65kr moving urlBuilder to bundle, as we talked some weeks ago, seems good to me.
But events are part of the model. To be honest, I would prefer to maintain the events in the library (the library is requiring another PHP library, not a Symfony Framework environment piece).
cv65kr
commented
Sep 17, 2018
I just remind You :)
Your argument seems good to me
I did not get any error about UrlBuilder part. Is this normal? I am using to build Zend module, and I used HTTP repositories mostly.
Edit:
I guess UrlBuidler is for the only extension for twig. I agree about moving.