Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Added EventDispatcher as dependency #56

Merged
mmoreram merged 1 commit into master from fix/added-event-dispatcher-dep
Sep 17, 2018

Conversation

@mmoreram
Copy link
Member

@mmoreram mmoreram commented Sep 17, 2018

  • Deleted composer.lock from repository

- Deleted composer.lock from repository
Copy link

cv65kr commented Sep 17, 2018

@mmoreram The same problem is with Apisearch\Url\UrlBuilder also require symfony/routing.
I think Events and UrlBuilder should be moved into apisearch-bundle. Client should be pure and universal without additional compontents. WDYT?

Copy link
Member Author

@cv65kr moving urlBuilder to bundle, as we talked some weeks ago, seems good to me.
But events are part of the model. To be honest, I would prefer to maintain the events in the library (the library is requiring another PHP library, not a Symfony Framework environment piece).

Copy link

cv65kr commented Sep 17, 2018

I just remind You :)
Your argument seems good to me

mmoreram reacted with thumbs up emoji

Copy link
Contributor

hkulekci commented Sep 17, 2018
edited
Loading

I did not get any error about UrlBuilder part. Is this normal? I am using to build Zend module, and I used HTTP repositories mostly.

Edit:

I guess UrlBuidler is for the only extension for twig. I agree about moving.

@mmoreram mmoreram merged commit 982cafd into master Sep 17, 2018
@mmoreram mmoreram deleted the fix/added-event-dispatcher-dep branch September 17, 2018 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@hkulekci hkulekci hkulekci approved these changes

@cv65kr cv65kr cv65kr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /