-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Docs (Symfony file upload): Change order of enabled formats #2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks @lucastrahlendorff indeed probably that multipart should be added only for the operation supporting it instead of being added globally anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having multipart at the first position of enabled formats in
api_platform.yamlnegatively affects the api (swagger) documentation. For some reason, all requests will be generated with 'accept: multipart/form-data', which is wrong for most endpoints. See the following GET request which is generated with the "accept: multipart/form-data" header (see the curl command below):image
This leads to responses with the error message "Serialization for the format "multipart" is not supported.".
Switching the formats in
api_platform.yamlto havejsonldat the first position solves this issue:Now, the request is generated and done properly with the correct accept header:
image
I was also able to reproduce this in version 4.0. This fix does not seem to have any other side effects on both versions 4.0 and 4.1. Can somebody confirm this?
Greetings!