-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix duplicate "Creating Custom Doctrine ORM filters" heading in documentation #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vinceAmstoutz
merged 1 commit into
api-platform:4.0
from
bumblecoder:bugfix/custom-filters-documentation-typo
Dec 6, 2024
Merged
Fix duplicate "Creating Custom Doctrine ORM filters" heading in documentation #2085
vinceAmstoutz
merged 1 commit into
api-platform:4.0
from
bumblecoder:bugfix/custom-filters-documentation-typo
Dec 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vinceAmstoutz please review
vinceAmstoutz
vinceAmstoutz
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tanks @bumblecoder!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a typo in the documentation where the "Creating Custom Doctrine ORM filters" heading is duplicated. The second heading, which links to the Elasticsearch filters documentation (https://api-platform.com/docs/core/elasticsearch-filters/#creating-custom-elasticsearch-filters), is incorrectly labeled as "Creating Custom Doctrine ORM filters."
Changes:
Updated the second duplicate heading to "Creating Custom Elasticsearch filters" for clarity and accuracy.
Why this change is needed:
The duplicate heading may confuse users, as the content under the second heading pertains to Elasticsearch filters rather than Doctrine ORM filters. Correcting this ensures the documentation is clear and easy to navigate.
Checklist:
image