Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: clean up docker cmds and improve code blocks #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@vinceAmstoutz
Copy link
Member

@vinceAmstoutz vinceAmstoutz commented Oct 17, 2024
edited
Loading

Partially solves #1995 by solving these 2 subtasks :

  • "Remove all docker compose prefixes for commands, as we don't use Docker for Laravel"
  • "Explain how to run commands with Symfony and Docker in the symfony/index.md"

⚠️ Don't forget to check the checkbox in the issue if the PR is merged

@vinceAmstoutz vinceAmstoutz changed the title (削除) docs: remove docker compose commands & use bash codeblocks over console (削除ここまで) (追記) docs: remove docker compose commands & improve codeblocks (追記ここまで) Oct 17, 2024
@vinceAmstoutz vinceAmstoutz force-pushed the docs-remove-docker-compose-prefixes branch from ff4f0b8 to b89b675 Compare October 17, 2024 08:51
@vinceAmstoutz vinceAmstoutz force-pushed the docs-remove-docker-compose-prefixes branch from cb02ffd to 513b3c3 Compare November 21, 2024 12:52
@vinceAmstoutz vinceAmstoutz changed the title (削除) docs: remove docker compose commands & improve codeblocks (削除ここまで) (追記) docs: clean up docker compose cmds and improve code blocks (追記ここまで) Nov 21, 2024
@vinceAmstoutz vinceAmstoutz changed the title (削除) docs: clean up docker compose cmds and improve code blocks (削除ここまで) (追記) refactor: clean up docker compose cmds and improve code blocks (追記ここまで) Nov 21, 2024
@vinceAmstoutz vinceAmstoutz changed the title (削除) refactor: clean up docker compose cmds and improve code blocks (削除ここまで) (追記) refactor: clean up docker cmds and improve code blocks (追記ここまで) Nov 21, 2024
@alanpoulain alanpoulain merged commit de4ec84 into api-platform:4.0 Nov 21, 2024
1 check passed
@vinceAmstoutz vinceAmstoutz deleted the docs-remove-docker-compose-prefixes branch November 21, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@soyuka soyuka Awaiting requested review from soyuka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /