-
-
Notifications
You must be signed in to change notification settings - Fork 77
refactor: Remove lodash.get dependency #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
@J3m5
J3m5
force-pushed
the
remove-lodash.get
branch
from
June 14, 2025 17:59
1631843 to
4a4f5ab
Compare
@J3m5
J3m5
force-pushed
the
remove-lodash.get
branch
2 times, most recently
from
June 15, 2025 17:18
c739b9d to
01354c9
Compare
@J3m5
J3m5
force-pushed
the
remove-lodash.get
branch
3 times, most recently
from
June 30, 2025 08:40
a8143f1 to
1e37761
Compare
@J3m5
J3m5
force-pushed
the
remove-lodash.get
branch
2 times, most recently
from
June 30, 2025 08:50
7423fa7 to
171cac0
Compare
* Removed duplicate definitions from `src/hydra/types.ts` and deleted `src/openapi3/types.ts`. * Added a single canonical `RequestInitExtended` interface in `src/types.ts`. * Updated all affected import paths across Hydra and OpenAPI3 modules. Signed-off-by: J3m5 <5523410+J3m5@users.noreply.github.com>
...stom guards * Introduce `src/openapi3/dereferencedOpenApiv3.ts`, providing fully-dereferenced versions of core OpenAPI 3 objects (Document, OperationObject, SchemaObject, etc.). * Refactor `handleJson.ts` to consume the new types: * Remove bespoke type-guard helpers (`isParameter`, `isSchema`, ...). * Eliminate most explicit `as` casts and manual type-narrowing logic. * Simplify enum/array handling through shared helpers (`buildEnumObject`, `getArrayType`). Signed-off-by: J3m5 <5523410+J3m5@users.noreply.github.com>
@J3m5
J3m5
force-pushed
the
remove-lodash.get
branch
from
June 30, 2025 08:54
171cac0 to
9c54332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the lodash.get dependency by replacing its calls with native optional chaining, destructuring, and default values, centralizes the RequestInitExtended type, and adds helper functions for enum and array handling.
- Replace all
lodash.getusages with optional chaining and default values - Consolidate
RequestInitExtendedinto a single definition insrc/types.ts - Introduce
buildEnumObjectandgetArrayTypein the OpenAPI v3 handler
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Add Nullable type and unified RequestInitExtended interface |
| src/swagger/handleJson.ts | Remove lodash.get, use destructuring/optional chaining, update import |
| src/openapi3/types.ts | Remove duplicate RequestInitExtended definition |
| src/openapi3/parseOpenApi3Documentation.ts | Update import of RequestInitExtended |
| src/openapi3/handleJson.ts | Replace lodash.get, add buildEnumObject/getArrayType, wrap parse |
| src/openapi3/dereferencedOpenApiv3.ts | Add types for dereferenced OpenAPI v3 schemas |
| src/hydra/types.ts | Remove duplicate RequestInitExtended definition |
| src/hydra/parseHydraDocumentation.ts | Remove lodash.get, use optional chaining |
| src/hydra/getParameters.ts | Update import of RequestInitExtended |
| src/hydra/fetchResource.ts | Update type imports |
| src/hydra/fetchJsonLd.ts | Update import of RequestInitExtended |
| package.json | Remove lodash.get and its types |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (4)
src/swagger/handleJson.ts:10
- Provide a descriptive message when throwing errors instead of using an empty Error().
return url.slice(0, -1);
src/openapi3/handleJson.ts:49
- [nitpick] Add a JSDoc comment explaining the purpose, inputs, and outputs of
buildEnumObjectto improve readability.
function buildEnumObject(enumArray: SchemaObjectDereferenced["enum"]) {
src/swagger/handleJson.ts:46
- Include an informative message in this thrown Error to aid debugging and remove the // @todo placeholder.
throw new Error(); // @TODO
src/swagger/handleJson.ts:8
- [nitpick] The
removeTrailingSlashfunction is duplicated insrc/openapi3/handleJson.ts; consider extracting it into a shared utility.
export function removeTrailingSlash(url: string): string {
@J3m5
J3m5
changed the title
(削除) Refactor: Remove lodash.get dependency (削除ここまで)
(追記) refactor: Remove lodash.get dependency (追記ここまで)
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Eliminate the lodash.get dependency and replace its usage with optional chaining, default values and type narrowing.
close #146