refactor(linter): migrate from eslint to oxlint #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

J3m5 merged 19 commits into main from oxlint

Jun 14, 2025

Merged

refactor(linter): migrate from eslint to oxlint #152

J3m5 merged 19 commits into main from oxlint

Jun 14, 2025

Conversation

@J3m5

Copy link

Contributor

@J3m5 J3m5 commented Jun 12, 2025 •

edited

Loading

Oxlint — A Quick Intro

Oxlint is a next-generation JavaScript / TypeScript linter written in Rust.
Its 1.0 "stable" release (10 Jun 2025) makes it a production-ready, drop-in alternative to ESLint with dramatic performance gains and native TypeScript parsing.

📚 Docs: oxc.rs/docs/guide/usage/linter
📰 1.0 announcement: oxc.rs/blog/2025-06-10-oxlint-stable

Key Advantages over ESLint

Brutal performance – Rust + SIMD + multithreading make Oxlint ~50-100 ×ばつ faster than ESLint in real-world benches.
Tiny memory footprint – avoids Node-JS heap spikes; runs comfortably under ~150 MB even on large codebases.
Better DX – colourful code-frames, inline autofix hints, and clearer wording cut review time.
TypeScript-first – parses TS natively; no separate @typescript-eslint stack required.
Drop-in coverage – 500 + rules today, plus an eslint-plugin-oxlint shim to smooth migration.
Single binary, tiny node_modules – the whole lint stack collapses from hundreds of JS packages to one ~5 MB binary.
Scales with core-count – automatic parallelism on CI runners; ESLint is single-threaded.

What this PR does

Remove ESLint and its config; add Oxlint.
Enable stricter tsconfig options (erasableSyntaxOnly, etc.) and fix resulting type errors.
Refactor source to satisfy new linting rules and improved type checks.
Update lint scripts (npm run lint) to call oxlint.

Changelog

Bug Fixes

(oxlint) yoda rule - (b902069)
(oxlint) eslint/func-style - (100b03c)
(oxlint) unicorn/no-array-for-each - (b8c7e44)
(oxlint) unicorn/no-useless-promise-resolve-reject - (f92d329)
(oxlint) import/no-anonymous-default-export - (dab3e98)
(oxlint) typescript/consistent-indexed-object-style - (bc8a7da)
(oxlint) unicorn/prefer-spread - (9a350bb)
(oxlint) typescript/consistent-type-definitions - (f6166ce)
(oxlint) unicorn/consistent-function-scoping - (a333717)
(oxlint) unicorn/prefer-string-slice - (d2927e5)
(oxlint) unicorn/prefer-type-error - (01b5d49)
(oxlint) yoda+eslint/no-negated-condition - (4b63ea8)
(oxlint) unicorn/prefer-array-some - (c49984a)
(oxlint) promise/prefer-await-to-callbacks + eslint/no-inner-declarations - (b141b93)
(oxlint) vitest - (6de19af)
(ts/oxlint) enable tsconfig compilerOptions and oxlint rules - (34f0c40)
(tsconfig) enable erasableSyntaxOnly and fix errors - (c6f425b)

Miscellaneous Chores

(lint-config) remove eslint config and add exlint config - (27b4db6)
(package.json) remove eslint and add oxlint - (2cd4171)

blocked by #151

@github-actions

Copy link

github-actions bot commented Jun 12, 2025 •

edited

Loading

Coverage Report

Status	Category	Percentage	Covered / Total
🟢	Lines	71.07% (🎯 70%)	285 / 401
🟢	Statements	71.11% (🎯 70%)	288 / 405
🟢	Functions	71.64% (🎯 70%)	48 / 67
🟢	Branches	58.77% (🎯 58%)	211 / 359

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/Api.ts	100%	100%	100%	100%
src/Field.ts	100%	100%	100%	100%
src/Operation.ts	100%	100%	100%	100%
src/Parameter.ts	100%	100%	100%	100%
src/Resource.ts	100%	100%	100%	100%
src/graphql/fetchQuery.ts	0%	0%	0%	0%	4-39
src/graphql/parseGraphQl.ts	0%	0%	0%	0%	13-120
src/hydra/fetchJsonLd.ts	100%	95%	100%	100%
src/hydra/fetchResource.ts	100%	60%	100%	100%
src/hydra/getParameters.ts	90%	75%	100%	88.88%	14
src/hydra/getType.ts	22.72%	21.95%	100%	22.72%	7-10, 16, 24-51, 56-66
src/hydra/parseHydraDocumentation.ts	87.02%	76.47%	91.66%	86.92%	35, 64-66, 72, 80-82, 86-88, 108-114, 120, 127-129, 205, 220, 283, 291-296, 391
src/openapi3/getType.ts	80%	60%	100%	80%	12
src/openapi3/handleJson.ts	91.2%	71.55%	93.75%	91.11%	46, 125, 169, 176, 184, 202, 213, 281
src/openapi3/parseOpenApi3Documentation.ts	0%	0%	0%	0%	17-40
src/swagger/handleJson.ts	82.75%	66.66%	100%	82.75%	11, 26, 35, 41, 48
src/swagger/parseSwaggerDocumentation.ts	0%	100%	0%	0%	15-35
src/utils/assignSealed.ts	100%	100%	100%	100%
src/utils/getResources.ts	100%	100%	100%	100%
src/utils/parsedJsonReplacer.ts	100%	100%	100%	100%

Generated in workflow #220 for commit 91c0cb8 by the Vitest Coverage Report Action

@J3m5 J3m5 self-assigned this

Jun 12, 2025

soyuka

soyuka approved these changes

Jun 13, 2025

View reviewed changes

@J3m5 J3m5 force-pushed the vitest branch from 4435eb5 to 13ed4b1 Compare

June 14, 2025 17:53

Base automatically changed from vitest to main

June 14, 2025 17:54

J3m5 added 19 commits

June 14, 2025 19:57

@J3m5


 chore(package.json): remove eslint and add oxlint

3df5236

@J3m5


 chore(lint-config): remove eslint config and add exlint config

4346de9

@J3m5


 fix(oxlint): yoda rule

25b7e12

https://oxc.rs/docs/guide/usage/linter/rules/eslint/yoda.html#eslint-yoda

@J3m5


 fix(oxlint): eslint/func-style

5143eb3

https://oxc.rs/docs/guide/usage/linter/rules/eslint/func-style.html

@J3m5


 fix(oxlint): unicorn/no-array-for-each

cf88ecd

https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-array-for-each.html

@J3m5


 fix(oxlint): unicorn/no-useless-promise-resolve-reject

https://oxc.rs/docs/guide/usage/linter/rules/unicorn/no-useless-promise-resolve-reject.html

@J3m5


 fix(oxlint): import/no-anonymous-default-export

8b143c0

https://oxc.rs/docs/guide/usage/linter/rules/import/no-anonymous-default-export.html

@J3m5


 fix(oxlint): typescript/consistent-indexed-object-style

580da02

https://oxc.rs/docs/guide/usage/linter/rules/typescript/consistent-indexed-object-style.html

@J3m5


 fix(oxlint): unicorn/prefer-spread

1df446a

https://oxc.rs/docs/guide/usage/linter/rules/unicorn/prefer-spread.html

@J3m5


 fix(oxlint): typescript/consistent-type-definitions

a4f79d6

https://oxc.rs/docs/guide/usage/linter/rules/typescript/consistent-type-definitions.html

@J3m5


 fix(oxlint): unicorn/consistent-function-scoping

632cc5e

https://oxc.rs/docs/guide/usage/linter/rules/unicorn/consistent-function-scoping.html

@J3m5


 fix(oxlint): unicorn/prefer-string-slice

7fbd4ca

https://oxc.rs/docs/guide/usage/linter/rules/unicorn/prefer-string-slice.html

@J3m5


 fix(oxlint): unicorn/prefer-type-error

248fd69

https://oxc.rs/docs/guide/usage/linter/rules/unicorn/prefer-type-error.html

@J3m5


 fix(oxlint): yoda+eslint/no-negated-condition

2c857ab

https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-negated-condition.html

@J3m5


 fix(oxlint): unicorn/prefer-array-some

eb82a83

https://oxc.rs/docs/guide/usage/linter/rules/unicorn/prefer-array-some.html

@J3m5


 fix(oxlint): promise/prefer-await-to-callbacks + eslint/no-inner-decl...

add57c8

...arations

@J3m5


 fix(oxlint): vitest

c63316e

- expect-expect
- no-conditional-expect
- no-conditional-in-test
- no-standalone-expect

@J3m5


 fix(tsconfig): enable erasableSyntaxOnly and fix errors

76de3cb

@J3m5


 fix(ts/oxlint): enable tsconfig compilerOptions and oxlint rules

91c0cb8

@J3m5 J3m5 force-pushed the oxlint branch from 34f0c40 to 91c0cb8 Compare

June 14, 2025 17:57

@J3m5 J3m5 merged commit 7a1e724 into main

Jun 14, 2025

1 check passed

@J3m5 J3m5 deleted the oxlint branch

June 14, 2025 17:58

Labels

None yet

3 participants

@J3m5 @soyuka

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(linter): migrate from eslint to oxlint #152

refactor(linter): migrate from eslint to oxlint #152

Uh oh!

Conversation

@J3m5 J3m5 commented Jun 12, 2025 •

edited

Loading

Uh oh!

Oxlint — A Quick Intro

Key Advantages over ESLint

What this PR does

Changelog

Bug Fixes

Miscellaneous Chores

Uh oh!

github-actions bot commented Jun 12, 2025 •

edited

Loading

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(linter): migrate from eslint to oxlint #152

refactor(linter): migrate from eslint to oxlint #152

Uh oh!

Conversation

@J3m5 J3m5 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Oxlint — A Quick Intro

Key Advantages over ESLint

What this PR does

Changelog

Bug Fixes

Miscellaneous Chores

Uh oh!

github-actions bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@J3m5 J3m5 commented Jun 12, 2025 •

edited

Loading

github-actions bot commented Jun 12, 2025 •

edited

Loading