-
Notifications
You must be signed in to change notification settings - Fork 320
[Blog] StarRocks and Apache Polaris Integration #2851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your blog post, @Youngwb ! It looks good to me overall... some comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polaris as an ASF project should remain vendor-neutral. I'm not sure this paragraph as it stands fits that model 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this mainly explains the advantages of combining Polaris and StarRocks, which are conclusions drawn from the characteristics of the two. Moreover, the descriptions below mention not only StarRocks but also other engines, such as Spark, Flink, and Trino.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spark, Flink, Trino are mentioned as sub-cases, while StarRocks appears to be elevated as a solution with a "performance advantage". I do not question that property of StarRocks, but it does not feel right to me to highlight that in a Polaris blog post.
Also "Business Value" appears to suggest deployment choices to the reader. I believe Polaris blogs should remain purely technical to avoid the impression of favouring one compatible engine over another.
In other words, why is this section specific (pairing) to StarRocks? IMHO, the previous sections provide sufficient details to the reader in order to form an independent opinion.
It is perfectly fine to link to StarRocks documentation that provides more details, of course (as done in other sections).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Business Value" is indeed a controversial term and I'd prefer to not not use it and stay purely technical in the blog post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified, please review it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Youngwb for adding it.
@xxubai
xxubai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: starrocks-polaris-intergration.md -> starrocks-polaris-integration.md
@xxubai
xxubai
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to specify that it uses a Shared-Data architecture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not necessary, users can choose the architecture they need for deployment.
@xxubai
xxubai
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the StarRocks Quick Start Guide for instructions on setting up a StarRocks cluster.
Which section should we include that in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to specify a particular section; users can choose a suitable deployment method through this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are published Docker images. Why do users have to build Polaris and the admin tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add link to Polaris quick-start guide , user can choose the way which suits them to deploy polairs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: now that we use 1.1.0 in this example, why bother with building from source? 1.1.0 has binary artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I also started to learn about Polaris from the Polaris Quick Start(https://polaris.apache.org/releases/1.1.0/getting-started/quickstart). This document starts with building Polaris, so I used this method before and only later learned about the binary artifacts. I added a link to the Polaris Quick Start in this documentation. I think we can add content about binary artifacts to the Polaris Quick Start later, this way, new users can directly deploy using the binary artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add per-engine docs under https://polaris.apache.org/in-dev/unreleased/getting-started/using-polaris/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense. It's out of scope of this PR though, this isn't a doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly not for this PR. This was just a general idea for enhancing our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks @Youngwb !
Let's wait for a few more reviews.
Add blog about how to integrate StarRocks with Apache Polaris