Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Extend Comments section with Use cases #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvazquez wants to merge 2 commits into apache:4.19
base: 4.19
Choose a base branch
Loading
from nvazquez:extend-annotations

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jan 7, 2025 •
edited by github-actions bot
Loading

Copy link
Contributor Author

nvazquez commented Jan 7, 2025

@blueorangutan docbuild

Copy link

@nvazquez a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/467. (QA-JID 297)

Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we need to clarify that users and admins can only add comments to objects they have the privileges to access!
  • some comments can be "admin-only", do we need to also think about what the domain admins can read/write, should a similar capability be extended to them?

Copy link
Contributor Author

nvazquez commented Jan 8, 2025

@blueorangutan docbuild

Copy link

@nvazquez a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/467. (QA-JID 298)

Copy link
Contributor

@nvazquez , this is how it is intended, isn't it? not how it works atm!

Copy link
Contributor Author

@DaanHoogland yes, but mostly its how its working besides the bug found, I'll add some additional notes or warnings

Copy link
Contributor

@NuxRo @nvazquez what is the status of this change? it is based on 4.19 and does not look like it is going to make 4.20, does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NuxRo NuxRo NuxRo requested changes

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

@shwstppr shwstppr Awaiting requested review from shwstppr

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /