-
Couldn't load subscription status.
- Fork 6.8k
Overlay popover adjustments #32199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Overlay popover adjustments #32199
+168
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for inserting the popovers ended up being identical between position strategies so these changes switch to handling it at the overlay level instead.
@crisbeto
crisbeto
requested review from
adolgachev and
andrewseguin
and removed request for
a team
October 29, 2025 09:23
@crisbeto
crisbeto
added
merge: preserve commits
When the PR is merged, a rebase and merge should be performed
target: rc
This PR is targeted for the next release-candidate
labels
Oct 29, 2025
@crisbeto
crisbeto
force-pushed
the
generic-overlay-popovers
branch
from
October 29, 2025 09:31
8597410 to
10b11a5
Compare
...rategy Updates the global position strategy to account for it being placed in a popover.
Updates the logic that sets `aria-hidden` on top-level elements to account for popovers.
Updates the select to account for the fact that when its overlay is rendered in a popover, the event bubbling order is different.
Updates the timepicker to account for the fact that the event bubbling will be different when we switch to using popovers.
@crisbeto
crisbeto
force-pushed
the
generic-overlay-popovers
branch
from
October 29, 2025 10:00
10b11a5 to
a830a82
Compare
andrewseguin
andrewseguin
approved these changes
Oct 29, 2025
@crisbeto
crisbeto
added
the
action: merge
The PR is ready for merge by the caretaker
label
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #32155 which includes the following changes: