Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(aria/combobox): adds disabled binding to aria combobox.ts #32150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
essjay05 wants to merge 1 commit into angular:main
base: main
Choose a base branch
Loading
from essjay05:aria-combobox-bind-disabled-attrs

Conversation

@essjay05
Copy link
Contributor

@essjay05 essjay05 commented Oct 22, 2025

Adds disabled binding to aria combobox.ts to have disabled attribute be automatically added as aria-disabled on the parent div and disabled on the input of combobox.

Screencast of my attempt at making a disabled demo using this attribute.

Adds disabled binding to aria combobox.ts to have disabled attribute
be automatically added as aria-disabled on the parent div and disabled
on the input of combobox.
@essjay05 essjay05 requested a review from a team as a code owner October 22, 2025 15:37
@essjay05 essjay05 requested review from andrewseguin and mmalerba and removed request for a team October 22, 2025 15:37
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 22, 2025
@mmalerba mmalerba requested review from wagnermaciel and removed request for mmalerba October 22, 2025 15:38
},
],
host: {
'[attr.aria-disabled]': 'disabled()',
Copy link
Contributor

@wagnermaciel wagnermaciel Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this aria-disabled on the combobox wrapper needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

detected: feature PR contains a feature commit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /