-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material/button): add missing tokens for hover, focus, and active pseudo-classes #30607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/button): add missing tokens for hover, focus, and active pseudo-classes #30607
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
...e pseudo-classes Add missing tokens for overriding hover, focus, and active outlines, as well as the label styling of the `outlined-button` in Angular Material. Fixes angular#30573
d114251 to
fd34195
Compare
@crisbeto
It looks like I missed some files.
- Could you clarify the difference between
m2/matandm2/mdc? Should I even add those tokens there? - Do I need to specify the tokens in
m3styles as well? - I ran the
material.angular.ioproject locally, but I don't see those tokens in the Styling tab. Shouldn't theextract-tokenstool automatically pick them up?
I’d really appreciate your support with this implementation.
Thanks in advance!
Add missing tokens for overriding hover, focus, and active outlines, as well as the label styling of the
outlined-buttonin Angular Material.Fixes #30573