-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(components/sort): add multi-sort support #28458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
572a6f2 to
bac7a65
Compare
bac7a65 to
978ee67
Compare
ricovivid
commented
Feb 20, 2024
@imerljak when in multi-sort will this also persist the visibility of the sort arrows when multiple columns are sorted?
@imerljak when in multi-sort will this also persist the visibility of the sort arrows when multiple columns are sorted?
You mean the visual feedback at the table header? Yep. If two cols are sorted they will render the header accordingly.
dsab123
commented
Mar 25, 2024
Just poking in to say that this is a great idea 👌 Thank you @imerljak and angular team!
978ee67 to
a6a59d5
Compare
amyngb
commented
Jul 10, 2024
Any updates on this PR?
labeled
commented
Oct 18, 2024
Any updates? It looks like the branch now has conflicts. This would be a great simple add feature.
I am happy to check this during the weekend and fix the conflicts. But I am not sure if it will ever get merged at this pace.
Adds multi-column sorting capability to MatSort, allowing to sort a table based on multiple columns at once by toggling matSortMultiple. This feature adds a new sortState variable inside MatSort that should be used as a source of truth when matSortMultiple is enabled. It also adds a two helper methods to check sort state: isActive, which returns if the provided column ID is currently sorted, and getCurrentSortDirection that returns the SortDirection of the provided column ID. Fixes angular#24102
a6a59d5 to
ce69439
Compare
Adds multi-column sorting capability to MatSort, allowing to sort a table on multiple of its columns at once by toggling matSortMultiple.
This feature adds a new sortState variable inside MatSort that should be used as a source of truth when matSortMultiple is enabled.
Fixes #24102