-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(cdk/menu): unable to close child menu with disabled items when us... #28097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/menu): unable to close child menu with disabled items when us... #28097
Conversation
6edf06b to
b17ba55
Compare
@crisbeto I can't figure out why autocomplete api golden checks fails, could you help?
thanks.
The check was broken on the main branch. It's fixed now so you need to rebase.
b96895b to
169d248
Compare
...ing keyboard Fixes the issue where the child menu remained open when all of its items were disabled.
169d248 to
b5129f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of going to the DOM, I think that we can check keyManager.activeItem === null here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed response, I tried it but didn't work, the keyManager.activeItem at this point is the child menu trigger button.
Fixes #27403.