Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BREAKING CHANGE: Remove ecs-8.x.php files to simplify configuration #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OndraM merged 1 commit into main from feature/extra-configs
May 13, 2024

Conversation

@OndraM
Copy link
Contributor

@OndraM OndraM commented May 9, 2024
edited
Loading

I tend to believe we no longer need these files with extra config for specific PHP version:

  • There aren't any check in them
  • Fixers which depends on some PHP version (eg. they require PHP 8.1 features) have version detection build inside them and they don't run if they detect unsupported PHP version
  • In case we would need such feature to make PHP version dependent config, we can do it directly in the ecs.php file (if (PHP_VERSION >= xxx) { ... })

So because of the near-to-zero value and to make the configuration simpler I suggest removing these extra files.

D0L1K reacted with thumbs up emoji
@OndraM OndraM force-pushed the feature/extra-configs branch from 1d63fbe to 6d4a645 Compare May 9, 2024 14:41
@OndraM OndraM merged commit 8e9163c into main May 13, 2024
@OndraM OndraM deleted the feature/extra-configs branch May 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirinovak jirinovak Awaiting requested review from jirinovak

@kdosiodjinud kdosiodjinud Awaiting requested review from kdosiodjinud

@MortalFlesh MortalFlesh Awaiting requested review from MortalFlesh

@hokypierce hokypierce Awaiting requested review from hokypierce

@MarketaSebkova MarketaSebkova Awaiting requested review from MarketaSebkova

1 more reviewer

@D0L1K D0L1K D0L1K approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

AltStyle によって変換されたページ (->オリジナル) /