-
Notifications
You must be signed in to change notification settings - Fork 11
BREAKING CHANGE: Remove ecs-8.x.php files to simplify configuration #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@OndraM
OndraM
requested review from
D0L1K,
MarketaSebkova,
MortalFlesh,
hokypierce,
jirinovak and
kdosiodjinud
May 9, 2024 14:24
@OndraM
OndraM
force-pushed
the
feature/extra-configs
branch
from
May 9, 2024 14:41
1d63fbe to
6d4a645
Compare
D0L1K
D0L1K
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I tend to believe we no longer need these files with extra config for specific PHP version:
if (PHP_VERSION >= xxx) { ... })So because of the near-to-zero value and to make the configuration simpler I suggest removing these extra files.