Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rename yml to yaml #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OndraM merged 1 commit into alma-oss:master from OndraM:feature/rename-to-yaml
Mar 27, 2018
Merged

Conversation

@OndraM
Copy link
Contributor

@OndraM OndraM commented Mar 26, 2018

easy-coding-standard.yaml wasn't previously autodiscovered by ECS (meaning you would have to define the path always), but is now, so we can switch to the recommended extension.

Copy link

TomasVotruba commented Mar 26, 2018
edited
Loading

I'd be careful about the validity of resources: https://stackoverflow.com/questions/21059124/is-it-yaml-or-yml#comment65070554_21059124

I prefer common sense with standard on Github - coverals.yml, travis.yml, yaml-sort-checker.yml...

This makes also point:
https://sourceforge.net/p/yaml/mailman/message/25795979/

While it may not seem a big deal, when one is frequently programming
for YAML files, it is much less troublesome and easier on the eyes to
write:

File.read('foo.yml')

then

File.read(Dir.glob('foo.{yml,yaml}'))

all the time.

E.g. this change caused impossible to use default value in Symfony Command, because 2 values are now "default".

Copy link
Contributor Author

OndraM commented Mar 26, 2018
edited
Loading

Important reason is that Symfony 4 switched to .yaml as default, in accordance with yaml.org recommendation (which is probably the only authoritative source regarding this).

So if you create Symfony 4 app, you will hardly anywhere use .yml (you don't configure Travis, Coveralls etc. for application). easy-coding-standard.yml would be the only place where you use .yml, which makes no sense to me...

screenshot_20180326_212630

Copy link

TomasVotruba commented Mar 26, 2018
edited
Loading

That is internal naming 1 framework, not root config standard.

Also, decision by popular project based on outdated source doesn't make the source valid.


I think is the new "tabs vs spaces" 😄 so let's stop before it becomes a thing and settle to prefer whatever we like.

@OndraM OndraM merged commit ffe291a into alma-oss:master Mar 27, 2018
@OndraM OndraM deleted the feature/rename-to-yaml branch April 3, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MortalFlesh MortalFlesh MortalFlesh approved these changes

@legendik legendik Awaiting requested review from legendik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /