-
Notifications
You must be signed in to change notification settings - Fork 11
Upgrade everything to its newest version, use PSR-12, support PHP 8.3 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve by functionality, but unfortunately I don't know the formal correctness of the rules in detail (in Agents projects it will change only 3 files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
thanks, I tried it on one repo and so far so good 👍 . I still want to to go through the rules and fixers (so maybe I will add some more comments tomorrow if I found some issue), but I don't want to delay what I found so far.
Apart from the inline comments:
- The github actions build was disabled by github (because there wasn't activity in the repo...) and needs to be updated. I enabled it, but you need to push some changes to trigger the build... And expect it to fail.
- There are examples in the README.md, which are not updated to the new configuration
- There is a small grammar typo in commit message (
it's->its), could you please fix this when you will be rebasing the commit before merge?
Thanks!
a748b08 to
dabd834
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
a96f5e1 to
be67c3d
Compare
No description provided.