-
Notifications
You must be signed in to change notification settings - Fork 11
Supports PHP 8+ #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports PHP 8+ #75
Conversation
bfe7492 to
6ef593a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do the same? (Also the other two below). If so, I'd choose one, preferably the PhpCsFixer.
They sometimes do different adjustments and makes unsolvable conflict. Also any fixer slows the execution down, so if they don't adds a value, we should not be using them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slevomat type hint sniffs handles superfluous annotations - I could not figure out how to remove them otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, this will make it not installable without copying repositories block to every composer.json using lmc/coding-standard 😬
ecs.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MortalFlesh is this necessary? symplify/easy-coding-standard:^10 seems to enable this by default as well :)
566f56d to
834ccdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameters->set(Option::PARALLEL, true); is not necessary IMO as it is on by default in ^10.0 :)
884e9df to
d06acf6
Compare
d06acf6 to
79a2ec4
Compare
No description provided.