-
Notifications
You must be signed in to change notification settings - Fork 11
Initial ECS setup according to current rules #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
.editorconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # http://editorconfig.org | ||
|
|
||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
| indent_style = space | ||
| indent_size = 4 | ||
|
|
||
| [*.{js,json,ts,tsx}] | ||
| indent_size = 4 | ||
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
187 changes: 187 additions & 0 deletions
easy-coding-standard.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| imports: | ||
| - { resource: 'vendor/symplify/easy-coding-standard/config/psr2.yml' } | ||
|
|
||
| services: | ||
| # Class and Interface names should be unique in a project, they should never be duplicated | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Classes\DuplicateClassNameSniff: ~ | ||
| # Control Structures must have at least one statement inside of the body (empty catch rules is skipped) | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\EmptyStatementSniff: ~ | ||
| # For loops that have only a second expression (the condition) should be converted to while loops | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\ForLoopShouldBeWhileLoopSniff: ~ | ||
| # Incrementers in nested loops should use different variable names | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\JumbledIncrementerSniff: ~ | ||
| # If statements that are always evaluated should not be used | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\UnconditionalIfStatementSniff: ~ | ||
| # Methods should not be declared final inside of classes that are declared final | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\UnnecessaryFinalModifierSniff: ~ | ||
| # Methods should not be defined that only call the parent method | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\UselessOverridingMethodSniff: ~ | ||
| # Doc comment formatting (but some of the rules are skipped) | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff: ~ | ||
| # Line length should not exceed 120 characters | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Files\LineLengthSniff: | ||
| absoluteLineLimit: 0 | ||
| lineLimit: 120 | ||
| # There should only be one class defined in a file | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Files\OneClassPerFileSniff: ~ | ||
| # There should only be one interface defined in a file | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Files\OneInterfacePerFileSniff: ~ | ||
| # There should only be one trait defined in a file | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Files\OneTraitPerFileSniff: ~ | ||
| # Exactly one space is allowed after a cast | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Formatting\SpaceAfterCastSniff: ~ | ||
| # Some functions should not appear in the code | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\PHP\ForbiddenFunctionsSniff: | ||
| forbiddenFunctions: | ||
| var_dump: null | ||
| dump: null | ||
| echo: null | ||
| require: null | ||
| require_once: null | ||
| include: null | ||
| include_once: null | ||
| phpinfo: null | ||
| eval: null | ||
| printf: null | ||
| # When referencing arrays you should not put whitespace around the opening bracket or before the closing bracket | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayBracketSpacingSniff: ~ | ||
| # Various array declaration rules (but some of the rules are skipped) | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff: ~ | ||
| # The self keyword should be used instead of the current class name | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Classes\SelfMemberReferenceSniff: ~ | ||
| # The asterisks in a doc comment should align, and there should be one space between the asterisk and tags | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Commenting\DocCommentAlignmentSniff: ~ | ||
| # Empty catch statements must have comment explaining why the exception is not handled | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Commenting\EmptyCatchCommentSniff: ~ | ||
| # Tests that the ++ operators are used when possible and not used when it makes the code confusing | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Operators\IncrementDecrementUsageSniff: ~ | ||
| # Verifies that class members have scope modifiers | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Scope\MemberVarScopeSniff: ~ | ||
| # Casts should not have whitespace inside the parentheses | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\CastSpacingSniff: ~ | ||
| # The php constructs like echo, return, include, etc. should have one space after them | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\LanguageConstructSpacingSniff: ~ | ||
| # Verifies that operators have valid spacing surrounding them | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\LogicalOperatorSpacingSniff: ~ | ||
| # Proper operator spacing | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\OperatorSpacingSniff: | ||
| ignoreNewlines: true | ||
| # The php keywords static, public, private, and protected should have one space after them | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ScopeKeywordSpacingSniff: ~ | ||
| # Semicolons should not have spaces before them | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\SemicolonSpacingSniff: ~ | ||
|
|
||
| PhpCsFixer\Fixer\Alias\MbStrFunctionsFixer: ~ | ||
| PhpCsFixer\Fixer\Alias\NoAliasFunctionsFixer: ~ | ||
| PhpCsFixer\Fixer\ArrayNotation\ArraySyntaxFixer: | ||
| syntax: short | ||
| PhpCsFixer\Fixer\ArrayNotation\NormalizeIndexBraceFixer: ~ | ||
| PhpCsFixer\Fixer\ArrayNotation\NoTrailingCommaInSinglelineArrayFixer: ~ | ||
| PhpCsFixer\Fixer\ArrayNotation\TrailingCommaInMultilineArrayFixer: ~ | ||
| PhpCsFixer\Fixer\ArrayNotation\TrimArraySpacesFixer: ~ | ||
| PhpCsFixer\Fixer\ArrayNotation\WhitespaceAfterCommaInArrayFixer: ~ | ||
| PhpCsFixer\Fixer\Basic\BracesFixer: | ||
| allow_single_line_closure: true | ||
| PhpCsFixer\Fixer\Basic\Psr4Fixer: ~ | ||
| PhpCsFixer\Fixer\Casing\NativeFunctionCasingFixer: ~ | ||
| PhpCsFixer\Fixer\CastNotation\CastSpacesFixer: ~ | ||
| PhpCsFixer\Fixer\CastNotation\LowercaseCastFixer: ~ | ||
| PhpCsFixer\Fixer\CastNotation\ShortScalarCastFixer: ~ | ||
| PhpCsFixer\Fixer\ClassNotation\ClassAttributesSeparationFixer: | ||
| elements: | ||
| - method | ||
| PhpCsFixer\Fixer\ClassNotation\NoBlankLinesAfterClassOpeningFixer: ~ | ||
| PhpCsFixer\Fixer\ClassNotation\SelfAccessorFixer: ~ | ||
| PhpCsFixer\Fixer\ClassNotation\VisibilityRequiredFixer: ~ | ||
| PhpCsFixer\Fixer\Comment\NoEmptyCommentFixer: ~ | ||
| PhpCsFixer\Fixer\ControlStructure\NoUselessElseFixer: ~ | ||
| PhpCsFixer\Fixer\ControlStructure\YodaStyleFixer: | ||
| equal: false | ||
| identical: false | ||
| less_and_greater: false | ||
| PhpCsFixer\Fixer\FunctionNotation\FunctionTypehintSpaceFixer: ~ | ||
| PhpCsFixer\Fixer\FunctionNotation\NoUnreachableDefaultArgumentValueFixer: ~ | ||
| PhpCsFixer\Fixer\Import\NoLeadingImportSlashFixer: ~ | ||
| PhpCsFixer\Fixer\Import\NoUnusedImportsFixer: | ||
| PhpCsFixer\Fixer\Import\OrderedImportsFixer: ~ | ||
| PhpCsFixer\Fixer\LanguageConstruct\IsNullFixer: | ||
| use_yoda_style: false | ||
| PhpCsFixer\Fixer\NamespaceNotation\NoLeadingNamespaceWhitespaceFixer: ~ | ||
| PhpCsFixer\Fixer\NamespaceNotation\SingleBlankLineBeforeNamespaceFixer: ~ | ||
| PhpCsFixer\Fixer\Operator\BinaryOperatorSpacesFixer: ~ | ||
| PhpCsFixer\Fixer\Operator\ConcatSpaceFixer: | ||
| spacing: one | ||
| PhpCsFixer\Fixer\Operator\NewWithBracesFixer: ~ | ||
| PhpCsFixer\Fixer\Operator\ObjectOperatorWithoutWhitespaceFixer: ~ | ||
| PhpCsFixer\Fixer\Operator\StandardizeNotEqualsFixer: ~ | ||
| PhpCsFixer\Fixer\Operator\TernaryOperatorSpacesFixer: ~ | ||
| PhpCsFixer\Fixer\Operator\UnaryOperatorSpacesFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\NoBlankLinesAfterPhpdocFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\NoEmptyPhpdocFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocAddMissingParamAnnotationFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocIndentFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocNoAccessFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocNoEmptyReturnFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocNoPackageFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocOrderFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocReturnSelfReferenceFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocScalarFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocSingleLineVarSpacingFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocTrimFixer: ~ | ||
| PhpCsFixer\Fixer\Phpdoc\PhpdocTypesFixer: ~ | ||
| PhpCsFixer\Fixer\PhpTag\FullOpeningTagFixer: ~ | ||
| PhpCsFixer\Fixer\PhpUnit\PhpUnitConstructFixer: ~ | ||
| PhpCsFixer\Fixer\PhpUnit\PhpUnitDedicateAssertFixer: ~ | ||
| PhpCsFixer\Fixer\ReturnNotation\NoUselessReturnFixer: ~ | ||
| PhpCsFixer\Fixer\Semicolon\NoEmptyStatementFixer: ~ | ||
| PhpCsFixer\Fixer\Semicolon\NoSinglelineWhitespaceBeforeSemicolonsFixer: ~ | ||
| PhpCsFixer\Fixer\Semicolon\SpaceAfterSemicolonFixer: ~ | ||
| PhpCsFixer\Fixer\StringNotation\SingleQuoteFixer: ~ | ||
| PhpCsFixer\Fixer\Whitespace\BlankLineBeforeStatementFixer: | ||
| statements: | ||
| - return | ||
| - try | ||
| PhpCsFixer\Fixer\Whitespace\NoExtraBlankLinesFixer: | ||
| tokens: | ||
| - break | ||
| - continue | ||
| - curly_brace_block | ||
| - extra | ||
| - parenthesis_brace_block | ||
| - return | ||
| - square_brace_block | ||
| - throw | ||
| - use | ||
| - use_trait | ||
| PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer: ~ | ||
|
|
||
| parameters: | ||
| skip: | ||
| # We allow empty catch statements (but they must have comment - see EmptyCatchCommentSniff) | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\EmptyStatementSniff.DetectedCatch: ~ | ||
|
|
||
| # Skip unwanted rules from DocCommentSniff | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.ContentAfterOpen: ~ | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.ContentBeforeClose: ~ | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.MissingShort: ~ | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.NonParamGroup: ~ | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.ParamGroup: ~ | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.ParamNotFirst: ~ | ||
| PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.TagValueIndent: ~ | ||
|
|
||
| # Skip unwanted rules from ArrayDeclarationSniff | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff.CloseBraceNotAligned: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff.DoubleArrowNotAligned: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff.KeyNotAligned: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff.MultiLineNotAllowed: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff.SingleLineNotAllowed: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff.ValueNotAligned: ~ | ||
|
|
||
| # There could be more than one space after star (eg. in Doctrine annotations) | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\Commenting\DocCommentAlignmentSniff.SpaceAfterStar: ~ | ||
|
|
||
| # Skip non-PSR2 rules incorrectly added by ECS (https://github.com/Symplify/Symplify/issues/696) | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.LineAfterClose: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.NoLineAfterClose: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.SpaceBeforeCloseBrace: ~ | ||
| PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.SpacingAfterOpenBrace: ~ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.