Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: to #47864637 修复STS登陆后地址栏工作不正常的问题 #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterRao merged 8 commits into aliyun:develop from shungang:csg/fix/develop/47864637
May 4, 2023

Conversation

@shungang
Copy link
Collaborator

@shungang shungang commented Feb 21, 2023

No description provided.

Copy link

CLAassistant commented Feb 21, 2023
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shungang
❌ chenshungang


chenshungang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

<div>
<div
ng-if="currentAuthInfo.id.indexOf('STS.')!=0"
ng-if="true || currentAuthInfo.id.indexOf('STS.')!=0"
Copy link
Contributor

@PeterRao PeterRao Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是测试代码?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是测试代码,这里为了代码留痕,所以这样写了,意思是不区分,是否是sts登陆都用address-bar.html这个组件
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你直接写到注释里面吧,别在代码里面写这个,不然后面维护的,看不懂这个逻辑

@PeterRao PeterRao merged commit 71ad3f8 into aliyun:develop May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PeterRao PeterRao PeterRao left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /