Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

improve environment variable implements #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacksonTian wants to merge 2 commits into master
base: master
Choose a base branch
Loading
from env
Open

improve environment variable implements #900

JacksonTian wants to merge 2 commits into master from env

Conversation

@JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Jun 12, 2024

No description provided.

}
}

public static void setEnvironmentAccessKeyId(String environmentAccessKeyId) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种方式还不能删掉,用户是可能会用到的,可以先置为弃用,标注弃用时间。时间到期再删。

@@ -1,48 +0,0 @@
package com.aliyuncs.utils;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种方式还不能删掉,用户是可能会用到的,可以先置为弃用,标注弃用时间。时间到期再删。

defaultProviders.add(new SystemPropertiesCredentialsProvider());
defaultProviders.add(new EnvironmentVariableCredentialsProvider());
defaultProviders.add(new ProfileCredentialsProvider());
String roleName = AuthUtils.getEnvironmentECSMetaData();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要保留和兼容之前的get方式,因为AuthUtils有对应的set方法

Copy link

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.92%. Comparing base (4368696) to head (13c630a).

Files Patch % Lines
...re/src/main/java/com/aliyuncs/utils/AuthUtils.java 60.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #900 +/- ##
============================================
- Coverage 89.98% 89.92% -0.07% 
+ Complexity 1654 1638 -16 
============================================
 Files 124 124 
 Lines 4734 4705 -29 
 Branches 544 543 -1 
============================================
- Hits 4260 4231 -29 
- Misses 347 348 +1 
+ Partials 127 126 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yndu13 yndu13 yndu13 left review comments

@xiahuai xiahuai Awaiting requested review from xiahuai xiahuai is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /