-
Notifications
You must be signed in to change notification settings - Fork 12
Added mem-dbg as optional feature #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI, the errors are caused by the CI configuration being old. Consider updating it.
Thanks for this! Let me know when done and will merge despite the outdated CI.
Hi @alecmocatta, sure - I am running some benchmarks so I may add some other small edits.
Why are you checking whether the estimates are three-sorted? I see that you run a binary search but that requires the estimates to be completely sorted, and I recently discovered that the estimates provided from the HLL++ paper are not sorted (they nearly are). I will be providing a fix for that shortly.
streaming_algorithms/src/distinct/consts.rs
Lines 33 to 45 in 99522db
Mem-dbg is a crate that allows to compute the size of a struct. I have added the derives through the crate as an optional feature, so as to use it to compare this implementation with others easily.
Cheers!