Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Script updates #118

Merged
Sjhunt93 merged 7 commits into main from script_updates
Sep 19, 2022
Merged

Script updates #118

Sjhunt93 merged 7 commits into main from script_updates
Sep 19, 2022

Conversation

@Sjhunt93
Copy link
Contributor

@Sjhunt93 Sjhunt93 commented Sep 1, 2022

No description provided.

@@ -1,3 +1,4 @@
from ast import arg
Copy link
Contributor

@martinezpl martinezpl Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS code 🤡

Copy link
Contributor Author

@Sjhunt93 Sjhunt93 Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh its a pain - need more C++ and xcode :P

dev.md Outdated
@@ -0,0 +1,3 @@
# Dev notes

To publish a new version, please run `bash publish.sh`.
Copy link
Contributor

@martinezpl martinezpl Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI handles publishing and updates latest version checks in SDKs on main branch tag, avoid manual publishing

Copy link
Contributor Author

@Sjhunt93 Sjhunt93 Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in the main readme? I just moved it. So just delete?

Copy link
Contributor

@martinezpl martinezpl Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok

Copy link
Contributor

@martinezpl martinezpl Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

Copy link
Contributor

@martinezpl martinezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@CodeBooster97 CodeBooster97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

```python
from apiaudio import Script
Script.create()
import apiaudio
Copy link
Contributor

@CodeBooster97 CodeBooster97 Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better


script = apiaudio.Script.create(
scriptText="<<sectionName::hello>> Hello {{username|buddy}} <<sectionName::bye>> Good bye from {{location|barcelona}}",
scriptText=text,
Copy link
Contributor

@CodeBooster97 CodeBooster97 Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaner

Copy link
Contributor

@springcoil springcoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sjhunt93 Sjhunt93 merged commit bdbb770 into main Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@LindaKivine LindaKivine Awaiting requested review from LindaKivine

3 more reviewers

@martinezpl martinezpl martinezpl approved these changes

@springcoil springcoil springcoil approved these changes

@CodeBooster97 CodeBooster97 CodeBooster97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /