Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: fix example json in template.md #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-Rickyy-b wants to merge 2 commits into adnanh:master
base: master
Choose a base branch
Loading
from d-Rickyy-b:fix-docs

Conversation

@d-Rickyy-b
Copy link

@d-Rickyy-b d-Rickyy-b commented Mar 28, 2023

Adds missing bracket.
Escapes quotes within a string.
Reformats whole example.

fixes #627

Adds missing bracket.
Escapes quotes within a string.
Reformats whole example.
fixes adnanh#627 
"secret": "{{ getenv "XXXTEST_SECRET" | js }}",
"parameter":
{
"secret": "{{ getenv \"XXXTEST_SECRET\" | js }}",
Copy link
Collaborator

@moorereason moorereason Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escaping these quotes is not accurate here. This is a Go template, not a JSON file.

d-Rickyy-b reacted with thumbs up emoji
Copy link
Author

@d-Rickyy-b d-Rickyy-b Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I did not read the template.md file properly when I created this PR. The missing [ is the only actual issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moorereason moorereason moorereason left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There is a syntax error in your templates file. Please fix for newer webhook users like myself.

AltStyle によって変換されたページ (->オリジナル) /